fix(ui): group arrays and reveal newly added editor elements - #1745
Merged
Merged
Conversation
Gordex2014
marked this pull request as draft
October 2, 2026 21:45
Gordex2014
marked this pull request as ready for review
October 2, 2026 22:27
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeated JSON elements were rendered as bare indices, and adding an element could leave its selector open while the new field stayed outside the visible tree. Arrays now have a named group with indexed entries and an appropriate action to add another item. Adding closes the initiating selector and focuses the exact new input, or the new complex row, scrolling within the tree only when needed.
The green success block is removed. A discreet row-local Undo removes the latest addition and restores focus to its originating action; a hidden status announces the change. Existing exit and unsaved-change confirmation paths remain available.
The shared behavior covers the standalone editor, Resources modal, View Definitions, SQL Queries Details and SQL Views Details, including entry from Search Parameters and Compartments. Collection rendering preserves schema-aware append offers, slices, repeating choices, unknown and empty arrays, validation diagnostics and indexed paths.
Dependent edits use the latest document, structural changes temporarily block controls with stale indices, and outdated JSON refreshes cannot replace a newly added row. Pointer activation preserves a dirty input until the click can queue its update and addition together. Failed updates retain the typed value and allow an explicit retry.
Validation:
Undo remains transient rather than a general edit history. Full workspace/backend matrices and remote CI are outside the completed focused verification.
Evidence: Before/after gallery — 18 captures across all five editor surfaces. Includes array grouping, primitive and complex additions, keyboard Undo, and Search Parameters/Compartments entry points. Temporary evidence expires 2026-10-07T18:44:18.998Z.
Closes #1720
Closes #1721