fix(ui): add cancel navigation to resource and SQL editors - #1763
Open
Gordex2014 wants to merge 5 commits into
Open
Gordex2014 wants to merge 5 commits into
Gordex2014 wants to merge 5 commits into
Conversation
…bels' into bugfix/1723-editor-navigation-r2
Gordex2014
changed the base branch from
bugfix/1720-repeating-element-labels
to
main
October 3, 2026 01:12
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
…vigation-r2 # Conflicts: # crates/ui/assets/editor.js # crates/ui/src/sql_export.rs # crates/ui/templates/pages/sql-library.html # crates/ui/templates/pages/sql-view-definitions.html
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating a SearchParameter currently provides no Cancel action or back link. Add consistent Cancel navigation to standalone resource, SearchParameter, CompartmentDefinition, ViewDefinition, SQL Query, and SQL View editors, preserving the opening page and guarding unsaved edits. Keep Delete unavailable for new drafts until a saved resource is confirmed. SQL Export links carry the return destination.
This is a separate follow-up to #1745 on the same editor code. Its commits remain included until #1745 merges; the #1723 changes leave the Resources modal unchanged.
Closes #1723.
Validation
Build, 138 JavaScript unit tests, 31 targeted browser tests, and four modal compatibility checks passed. After syncing the corrected base, all-targets UI Clippy, formatting, the affected accordion test, and six SQL navigation tests also passed.
Visual evidence
Before and after — All surfaces · Desktop · Light
Evidence expires October 9, 2026 at 22:20 UTC. Resources modal and SQL Export screenshots are excluded.