Repository navigation
perf(detection): charge the scan budget per pass and cut monitor overhead - #94
Merged
Merged
Conversation
…attern The per-request scan budget read getrusage() twice per pattern. It now reads the CPU clock when a pass opens, at each 2 ms wall-clock slice boundary and when the pass closes, matching the reference engine. The exhausted check stays arithmetic-only, so the budget lags by at most one slice plus one pattern.
github-actions
Bot
added
area: detection
…ate waiver to its new lines
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #93
Port of the reference fix in Guard-Core/guard-core#173. checkRegexPatterns opens a pass with one cpuSeconds() reading (only when a budget is active), scanPatternCharged compares hrtime against the request-scoped slice start after each pattern and charges the CPU clock only when 2 ms have elapsed, and a finally makes the final charge; beginScan starts the slice so it spans values, and scanBudgetExhausted() stays arithmetic only. The $cpuClock hook still works, and a $wallClockNs test hook drives the slice deterministically. The performance monitor returns before sanitizing when no callback is registered. Tests cover the clock reads per pass and a long pass stopping within about one slice. On a ~1.1 KB JSON-like body plus 10 headers detection went from 17.6 ms to 15.1 ms of CPU.