Skip to content

clang-tidy: resolve readability-use-anyofallof #805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
knoepfel wants to merge 3 commits into
base: main
Choose a base branch
from
Open

clang-tidy: resolve readability-use-anyofallof #805

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c11a25
Resolve readability-use-anyofallof clang-tidy warning
knoepfel Aug 5, 2026
7ad0299
docs: record PR #805 for readability-use-anyofallof clang-tidy fixes
knoepfel Aug 5, 2026
e28a69e
Constrain capture list
knoepfel Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/dev/clang-tidy-fixes-2026-04.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,7 @@
- [x] [readability-static-definition-in-anonymous-namespace](https://clang.llvm.org/extra/clang-tidy/checks/readability/static-definition-in-anonymous-namespace.html) (12)
- [PR #742](https://github.com/Framework-R-D/phlex/pull/742)
- [ ] [readability-static-accessed-through-instance](https://clang.llvm.org/extra/clang-tidy/checks/readability/static-accessed-through-instance.html) (10)
- [ ] [readability-use-anyofallof](https://clang.llvm.org/extra/clang-tidy/checks/readability/use-anyofallof.html) (2)
- [x] [readability-use-anyofallof](https://clang.llvm.org/extra/clang-tidy/checks/readability/use-anyofallof.html) (2)
- [PR #805](https://github.com/Framework-R-D/phlex/pull/805)
- [x] [readability-use-concise-preprocessor-directives](https://clang.llvm.org/extra/clang-tidy/checks/readability/use-concise-preprocessor-directives.html) (201)
- [PR #772](https://github.com/Framework-R-D/phlex/pull/772)
8 changes: 2 additions & 6 deletions form/storage/storage_reader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,12 +147,8 @@ namespace {
if (components.empty()) {
return false;
}
for (auto const& [_, value] : components) {
if (value != 0) {
return false;
}
}
return true;
return std::ranges::all_of(components,
[](auto const& component) { return component.second == 0; });
}

std::optional<int> sequential_row_from_index_id(std::string const& id)
Expand Down
123 changes: 68 additions & 55 deletions plugins/python/src/modulewrap.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -896,6 +896,69 @@ static std::optional<std::string_view> collection_dtype(std::string const& type_
return std::string_view{type_name}.substr(pos);
}

static bool insert_input_converter(py_phlex_module* mod,
std::string const& cname, // TODO: shared_ptr<PyObject>
size_t i,
product_selector const& inp_pq,
std::string const& inp_type,
bool ispy,
concurrency nc)
{
// insert a single input converter node into the graph
// TODO: this seems overly verbose and inefficient, but the function needs
// to be properly types, so every option is made explicit

std::string const& pyname = input_converter_name(cname, i);
std::string output =
"py_" + (inp_pq.suffix ? std::string{static_cast<std::string_view>(*inp_pq.suffix)} : "");

if (inp_type == "bool") {
insert_converter(mod, pyname, ispy ? bool_to_py : bool_to_dcarg, inp_pq, output, nc);
} else if (inp_type == "int32_t") {
insert_converter(mod, pyname, ispy ? int_to_py : int_to_dcarg, inp_pq, output, nc);
} else if (inp_type == "uint32_t") {
insert_converter(mod, pyname, ispy ? uint_to_py : uint_to_dcarg, inp_pq, output, nc);
} else if (inp_type == "int64_t") {
insert_converter(mod, pyname, ispy ? long_to_py : long_to_dcarg, inp_pq, output, nc);
} else if (inp_type == "uint64_t") {
insert_converter(mod, pyname, ispy ? ulong_to_py : ulong_to_dcarg, inp_pq, output, nc);
} else if (inp_type == "float") {
insert_converter(mod, pyname, ispy ? float_to_py : float_to_dcarg, inp_pq, output, nc);
} else if (inp_type == "double") {
insert_converter(mod, pyname, ispy ? double_to_py : double_to_dcarg, inp_pq, output, nc);
} else if (inp_type.starts_with("ndarray") || inp_type.starts_with("list")) {
// TODO: these are hard-coded std::vector <-> numpy array mappings, which is
// way too simplistic for real use. It only exists for demonstration purposes,
// until we have an IDL
auto const dtype = collection_dtype(inp_type);
if (!dtype) {
PyErr_Format(PyExc_TypeError, "unsupported collection input type \"%s\"", inp_type.c_str());
return false;
}
if (*dtype == "[int32_t]") {
insert_converter(mod, pyname, vint_to_py, inp_pq, output, nc);
} else if (*dtype == "[uint32_t]") {
insert_converter(mod, pyname, vuint_to_py, inp_pq, output, nc);
} else if (*dtype == "[int64_t]") {
insert_converter(mod, pyname, vlong_to_py, inp_pq, output, nc);
} else if (*dtype == "[uint64_t]") {
insert_converter(mod, pyname, vulong_to_py, inp_pq, output, nc);
} else if (*dtype == "[float]") {
insert_converter(mod, pyname, vfloat_to_py, inp_pq, output, nc);
} else if (*dtype == "[double]") {
insert_converter(mod, pyname, vdouble_to_py, inp_pq, output, nc);
} else {
PyErr_Format(PyExc_TypeError, "unsupported collection input type \"%s\"", inp_type.c_str());
return false;
}
} else {
PyErr_Format(PyExc_TypeError, "unsupported input type \"%s\"", inp_type.c_str());
return false;
}

return true;
}

static bool insert_input_converters(py_phlex_module* mod,
std::string const& cname, // TODO: shared_ptr<PyObject>
std::vector<product_selector> const& input_selectors,
Expand All @@ -904,61 +967,11 @@ static bool insert_input_converters(py_phlex_module* mod,
concurrency nc)
{
// insert input converter nodes into the graph
for (auto const [i, inp_pq, inp_type] :
std::views::zip(std::views::iota(size_t{}), input_selectors, input_types)) {
// TODO: this seems overly verbose and inefficient, but the function needs
// to be properly types, so every option is made explicit

std::string const& pyname = input_converter_name(cname, i);
std::string output =
"py_" + (inp_pq.suffix ? std::string{static_cast<std::string_view>(*inp_pq.suffix)} : "");

if (inp_type == "bool") {
insert_converter(mod, pyname, ispy ? bool_to_py : bool_to_dcarg, inp_pq, output, nc);
} else if (inp_type == "int32_t") {
insert_converter(mod, pyname, ispy ? int_to_py : int_to_dcarg, inp_pq, output, nc);
} else if (inp_type == "uint32_t") {
insert_converter(mod, pyname, ispy ? uint_to_py : uint_to_dcarg, inp_pq, output, nc);
} else if (inp_type == "int64_t") {
insert_converter(mod, pyname, ispy ? long_to_py : long_to_dcarg, inp_pq, output, nc);
} else if (inp_type == "uint64_t") {
insert_converter(mod, pyname, ispy ? ulong_to_py : ulong_to_dcarg, inp_pq, output, nc);
} else if (inp_type == "float") {
insert_converter(mod, pyname, ispy ? float_to_py : float_to_dcarg, inp_pq, output, nc);
} else if (inp_type == "double") {
insert_converter(mod, pyname, ispy ? double_to_py : double_to_dcarg, inp_pq, output, nc);
} else if (inp_type.starts_with("ndarray") || inp_type.starts_with("list")) {
// TODO: these are hard-coded std::vector <-> numpy array mappings, which is
// way too simplistic for real use. It only exists for demonstration purposes,
// until we have an IDL
auto const dtype = collection_dtype(inp_type);
if (!dtype) {
PyErr_Format(PyExc_TypeError, "unsupported collection input type \"%s\"", inp_type.c_str());
return false;
}
if (*dtype == "[int32_t]") {
insert_converter(mod, pyname, vint_to_py, inp_pq, output, nc);
} else if (*dtype == "[uint32_t]") {
insert_converter(mod, pyname, vuint_to_py, inp_pq, output, nc);
} else if (*dtype == "[int64_t]") {
insert_converter(mod, pyname, vlong_to_py, inp_pq, output, nc);
} else if (*dtype == "[uint64_t]") {
insert_converter(mod, pyname, vulong_to_py, inp_pq, output, nc);
} else if (*dtype == "[float]") {
insert_converter(mod, pyname, vfloat_to_py, inp_pq, output, nc);
} else if (*dtype == "[double]") {
insert_converter(mod, pyname, vdouble_to_py, inp_pq, output, nc);
} else {
PyErr_Format(PyExc_TypeError, "unsupported collection input type \"%s\"", inp_type.c_str());
return false;
}
} else {
PyErr_Format(PyExc_TypeError, "unsupported input type \"%s\"", inp_type.c_str());
return false;
}
}

return true;
auto const converters = std::views::zip(std::views::iota(size_t{}), input_selectors, input_types);
return std::ranges::all_of(converters, [mod, &cname, ispy, nc](auto const& converter) {

@beojan beojan Aug 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure all_of is appropriate here. We have a loop where the side effects are what's important.

auto const& [i, inp_pq, inp_type] = converter;
return insert_input_converter(mod, cname, i, inp_pq, inp_type, ispy, nc);
});
}

static bool insert_output_converter(py_phlex_module* mod,
Expand Down
Loading