Skip to content

clang-tidy: resolve readability-use-anyofallof - #805

Open
knoepfel wants to merge 3 commits into
Framework-R-D:mainfrom
knoepfel:readability-use-anyofallof
Open

clang-tidy: resolve readability-use-anyofallof#805
knoepfel wants to merge 3 commits into
Framework-R-D:mainfrom
knoepfel:readability-use-anyofallof

Conversation

@knoepfel

@knoepfel knoepfel commented Aug 5, 2026

Copy link
Copy Markdown
Member

Resolve readability-use-anyofallof clang-tidy warnings.

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@knoepfel, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 17 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 19d0f1de-e506-405e-a72e-1b0147ff9437

📥 Commits

Reviewing files that changed from the base of the PR and between 240a461 and e28a69e.

📒 Files selected for processing (3)
  • docs/dev/clang-tidy-fixes-2026-04.md
  • form/storage/storage_reader.cpp
  • plugins/python/src/modulewrap.cpp

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.41667% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
plugins/python/src/modulewrap.cpp 84.78% 4 Missing and 3 partials ⚠️
@@            Coverage Diff             @@
##             main     #805      +/-   ##
==========================================
+ Coverage   83.89%   83.93%   +0.04%     
==========================================
  Files         171      171              
  Lines        7234     7235       +1     
  Branches      850      847       -3     
==========================================
+ Hits         6069     6073       +4     
+ Misses        881      879       -2     
+ Partials      284      283       -1     
Flag Coverage Δ
scripts 80.09% <ø> (ø)
unittests 85.85% <85.41%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
form/storage/storage_reader.cpp 82.32% <100.00%> (+0.75%) ⬆️
plugins/python/src/modulewrap.cpp 75.45% <84.78%> (-0.04%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 240a461...e28a69e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.


return true;
auto const converters = std::views::zip(std::views::iota(size_t{}), input_selectors, input_types);
return std::ranges::all_of(converters, [mod, &cname, ispy, nc](auto const& converter) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure all_of is appropriate here. We have a loop where the side effects are what's important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants