clang-tidy: resolve readability-use-anyofallof - #805
Conversation
|
Warning Review limit reached
Next review available in: 17 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #805 +/- ##
==========================================
+ Coverage 83.89% 83.93% +0.04%
==========================================
Files 171 171
Lines 7234 7235 +1
Branches 850 847 -3
==========================================
+ Hits 6069 6073 +4
+ Misses 881 879 -2
+ Partials 284 283 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
|
||
| return true; | ||
| auto const converters = std::views::zip(std::views::iota(size_t{}), input_selectors, input_types); | ||
| return std::ranges::all_of(converters, [mod, &cname, ispy, nc](auto const& converter) { |
There was a problem hiding this comment.
I'm not sure all_of is appropriate here. We have a loop where the side effects are what's important.
Resolve
readability-use-anyofallofclang-tidy warnings.