Skip to content

fix(player): close live chat beside the video and show it again - #550

Merged
A-EDev merged 1 commit into
mainfrom
fix/live-chat-close
Nov 10, 2026
Merged

A-EDev merged 1 commit into
mainfrom
fix/live-chat-close

Conversation

@A-EDev

@A-EDev A-EDev commented Nov 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Live chat and chat replay beside the video have a close button in their header.
  • A closed chat leaves a "Show chat" (or "Show chat replay") button in its place, so it can come back even when the player's chat button is hidden in Settings.
  • The player's chat button now works outside fullscreen too and shows whether the chat is open. It still follows the Live chat setting under player buttons.
  • Chat opens again for each new video and when the player is closed.

Split out of #437, which is Captain-Vikram's work. Co-authored with him.

Related issue

Closes #435

Change type

  • Bug fix
  • Feature
  • Refactor or maintenance
  • Documentation
  • Build, packaging, or CI

Validation

  • pnpm test (387 files, 2294 tests, 0 failures)
  • pnpm build (tsc and vite build pass)
  • cargo fmt --manifest-path src-tauri/Cargo.toml --all -- --check
  • cargo clippy --manifest-path src-tauri/Cargo.toml --all-targets --all-features
  • cargo test --manifest-path src-tauri/Cargo.toml --all-targets --all-features
  • I smoke-tested the affected desktop behavior.

No Rust files change. New tests cover closing the chat, the Show chat button bringing it back, and the store resetting it per video. Not run in the app yet.

Screenshots or recordings

Risk and compatibility

  • No new secrets, private data, telemetry, or broad Tauri permissions were introduced.
  • User-facing documentation was updated where needed.
  • Dependency and lockfile changes are intentional and limited to this PR.
  • Breaking changes and upgrade steps are clearly documented.

Frontend only: one new player store flag and two new strings. No database, network or playback change.

Co-authored-by: Captain-Vikram <vighneshkontham@gmail.com>
Copilot AI balanced review requested due to automatic review settings November 10, 2026 17:31

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@A-EDev
A-EDev merged commit f702d12 into main Nov 10, 2026
7 checks passed
@A-EDev
A-EDev deleted the fix/live-chat-close branch November 10, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: No option to close or hide the Live Chat / Chat Replay panel

2 participants