Repository navigation
fix(player): close live chat beside the video and show it again - #550
Merged
Merged
Conversation
Co-authored-by: Captain-Vikram <vighneshkontham@gmail.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
7 of 15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Split out of #437, which is Captain-Vikram's work. Co-authored with him.
Related issue
Closes #435
Change type
Validation
pnpm test(387 files, 2294 tests, 0 failures)pnpm build(tsc and vite build pass)cargo fmt --manifest-path src-tauri/Cargo.toml --all -- --checkcargo clippy --manifest-path src-tauri/Cargo.toml --all-targets --all-featurescargo test --manifest-path src-tauri/Cargo.toml --all-targets --all-featuresNo Rust files change. New tests cover closing the chat, the Show chat button bringing it back, and the store resetting it per video. Not run in the app yet.
Screenshots or recordings
Risk and compatibility
Frontend only: one new player store flag and two new strings. No database, network or playback change.