Skip to content

fix(music): open each credited artist from the player and track lists - #437

Merged
A-EDev merged 5 commits into
Flow-Tube:mainfrom
Captain-Vikram:fix/issue-428-secondary-artist-navigation
Nov 10, 2026
Merged

A-EDev merged 5 commits into
Flow-Tube:mainfrom
Captain-Vikram:fix/issue-428-secondary-artist-navigation

Conversation

@Captain-Vikram

@Captain-Vikram Captain-Vikram commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Each credited artist on a song is its own link in the full player and in track lists, so a featured artist opens their own page instead of the first artist's.
  • One ArtistLinks component draws these links for both places. Each name reads in its own text direction and shows a focus ring.
  • In a track row, clicking or pressing Enter on an artist opens the artist without playing the song. While rows are being selected, the names are plain text.
  • With several artists, the song menu has one "View artist: name" item per artist, from a new string with a placeholder.

The live chat half of this PR moved to #550.

Related issue

Closes #428

Change type

  • Bug fix
  • Feature
  • Refactor or maintenance
  • Documentation
  • Build, packaging, or CI

Validation

  • pnpm test (389 files, 2299 tests, 0 failures)
  • pnpm build (tsc and vite build pass)
  • cargo fmt --manifest-path src-tauri/Cargo.toml --all -- --check
  • cargo clippy --manifest-path src-tauri/Cargo.toml --all-targets --all-features
  • cargo test --manifest-path src-tauri/Cargo.toml --all-targets --all-features
  • I smoke-tested the affected desktop behavior.

No Rust files change. Tests cover separate links, Enter on an artist not reaching the row, plain names during selection, and one menu item per artist. Not run in the app yet.

Screenshots or recordings

Risk and compatibility

  • No new secrets, private data, telemetry, or broad Tauri permissions were introduced.
  • User-facing documentation was updated where needed.
  • Dependency and lockfile changes are intentional and limited to this PR.
  • Breaking changes and upgrade steps are clearly documented.

Music UI only, plus one new string. No database, network or playback change.

@Captain-Vikram Captain-Vikram changed the title fix(music,player): secondary artist navigation (#428) and live chat toggle fix(music,player): secondary artist navigation (#428) and live chat toggle (#435) Nov 6, 2026
2ax4 pushed a commit to 2ax4/Flow-Desktop that referenced this pull request Nov 6, 2026
…live chat toggle

# Conflicts:
#	src/components/player/FlowPlayerControls.tsx
#	src/store/usePlayerStore.ts
@Captain-Vikram
Captain-Vikram force-pushed the fix/issue-428-secondary-artist-navigation branch from 0b89448 to ff6e127 Compare November 7, 2026 06:14
A-EDev and others added 4 commits November 10, 2026 19:07
Co-authored-by: Captain-Vikram <vighneshkontham@gmail.com>
…ry-artist-navigation

# Conflicts:
#	src/components/music/AlbumTrackRow.tsx
#	src/components/music/player/NowPlayingColumn.tsx
Co-authored-by: Captain-Vikram <vighneshkontham@gmail.com>
Co-authored-by: Captain-Vikram <vighneshkontham@gmail.com>
@A-EDev A-EDev changed the title fix(music,player): secondary artist navigation (#428) and live chat toggle (#435) fix(music): open each credited artist from the player and track lists Nov 10, 2026
@A-EDev
A-EDev merged commit 89ff16f into Flow-Tube:main Nov 10, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Clicking a secondary artist in a multi-artist track opens the primary artist's page

2 participants