Repository navigation
Conversation
2ax4
pushed a commit
to 2ax4/Flow-Desktop
that referenced
this pull request
Nov 6, 2026
…live chat toggle # Conflicts: # src/components/player/FlowPlayerControls.tsx # src/store/usePlayerStore.ts
Captain-Vikram
force-pushed
the
fix/issue-428-secondary-artist-navigation
branch
from
November 7, 2026 06:14
0b89448 to
ff6e127
Compare
Co-authored-by: Captain-Vikram <vighneshkontham@gmail.com>
…ry-artist-navigation # Conflicts: # src/components/music/AlbumTrackRow.tsx # src/components/music/player/NowPlayingColumn.tsx
Co-authored-by: Captain-Vikram <vighneshkontham@gmail.com>
Co-authored-by: Captain-Vikram <vighneshkontham@gmail.com>
7 of 15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ArtistLinkscomponent draws these links for both places. Each name reads in its own text direction and shows a focus ring.The live chat half of this PR moved to #550.
Related issue
Closes #428
Change type
Validation
pnpm test(389 files, 2299 tests, 0 failures)pnpm build(tsc and vite build pass)cargo fmt --manifest-path src-tauri/Cargo.toml --all -- --checkcargo clippy --manifest-path src-tauri/Cargo.toml --all-targets --all-featurescargo test --manifest-path src-tauri/Cargo.toml --all-targets --all-featuresNo Rust files change. Tests cover separate links, Enter on an artist not reaching the row, plain names during selection, and one menu item per artist. Not run in the app yet.
Screenshots or recordings
Risk and compatibility
Music UI only, plus one new string. No database, network or playback change.