Skip to content

Reject reversed scalar hypertoroidal integration bounds #5401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FlorianPfaff merged 1 commit into from
Aug 23, 2026
Merged

Reject reversed scalar hypertoroidal integration bounds #5401

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/pyrecest/distributions/hypertorus/hypertoroidal_uniform_distribution.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,10 +184,6 @@ def _validate_boundary(name: str, value, dim: int):


def _validate_boundary_order(left, right) -> None:
# Scalar 1-D limits retain the signed-integration convention used by the
# circular API. Vector limits describe hyperrectangles and must be ordered.
if ndim(left) == 0 and ndim(right) == 0:
return
if not bool(backend_all(right >= left)):
raise ValueError("integration boundaries must be increasing in every dimension")

Expand Down
Loading