Reject reversed scalar hypertoroidal integration bounds - #5401
Merged
FlorianPfaff merged 1 commit intoAug 23, 2026
Conversation
FlorianPfaff
added a commit
that referenced
this pull request
Aug 23, 2026
Revert the scalar-boundary regression introduced by #5401 while preserving reversed vector-bound validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
HypertoroidalUniformDistribution.integrate(...)so scalar 1-D boundaries obey the same increasing-boundary contract as vector boundaries.The current helper special-cases scalar limits and permits
(1.0, 0.0), returning a negative probability mass. This contradicts the existing regression testtest_integrate_rejects_reversed_one_dimensional_boundaries, which already verifies both scalar and length-one vector inputs.Fix
Remove the scalar bypass in
_validate_boundary_order, so all supported boundary representations rejectright < leftwith the existingValueError.Regression
The repository already contains
tests/distributions/test_hypertoroidal_uniform_scalar_boundary_order.py; this patch makes its scalar case pass and also resolves the unrelated failure observed in the full CI artifacts of the open bug-fix PRs.