Add optional protocol and KCX_BTAUDIO build flags - #149
Merged
Conversation
Adds pxx1, pxx2, ghost, multi, dsmp and afhds3 as global build flags so individual radio protocol modules can be disabled at build-request time, useful for flash-constrained targets such as translation builds (#148). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Adds an opt-in kcx_btaudio build flag (-DKCX_BTAUDIO=YES) scoped to the tx15 and tx16smk3 targets via a new tag, matching the existing bluetooth tag pattern. Available since firmware v3.0 nightly (EdgeTX/edgetx#6777, EdgeTX/edgetx#7056) (#133). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pxx1,pxx2,ghost,multi,dsmp,afhds3) so individual radio protocol modules can be disabled at build-request time, useful for flash-constrained targets such as translation builds (closes add options to turn off PXX1, PXX2, GHOST, MULTI, DSMP, AFHDS3 #148)kcx_btaudioflag scoped to thetx15andtx16smk3targets via a new tag, mirroring the existingbluetoothtag pattern, for-DKCX_BTAUDIO=YESsupport added in firmware v3.0 nightly (feat(tx15): support for KCX BT audio edgetx#6777, feat(radio): bluetooth audio KCX mod support for TX16S MK3 edgetx#7056) (closes chore: add KCX_BTAUDIO #133)Both changes are pure
targets.jsondata additions — cloudbuild's flag validation, cmake-arg generation, DB storage, and UI "Add Flag" picker are already fully generic and required no Go or frontend code changes.Test plan
jq . targets.jsonvalidatesgo build ./...go test ./targets/... ./firmware/...passgo run ./cmd/ebuild run api) against thistargets.json:GET /api/targetsreturns the new flags/tags in the exact shape the UI consumesPOST /api/jobswithpxx2=NO+ghost=NOonx10express→201, resolved tobuild_flags: [{"key":"GHOST","value":"NO"},{"key":"PXX2","value":"NO"}]POST /api/jobswithkcx_btaudio=YESontx15→201, resolved to-DKCX_BTAUDIO=YESkcx_btaudio=YESonx10express(nokcx_btaudiotag) →422 option flag not supported, confirming tag-scoping correctly restricts it🤖 Generated with Claude Code