Add module size override flags - #150
Open
pfeerick wants to merge 1 commit into
Open
Conversation
Adds global module_size_std and module_size_sml flags mapping to -DMODULE_SIZE_STD=<value> / -DMODULE_SIZE_SML=<value>, letting a build request override the external module bay size EdgeTX compiles for (the two macros are independent gates on which module types appear in the menu, not mutually exclusive, so both can be toggled freely) (#78). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
module_size_std/module_size_smlflags mapping to-DMODULE_SIZE_STD=<value>/-DMODULE_SIZE_SML=<value>(closes add module size override flags #78)MODULE_SIZE_STD/MODULE_SIZE_SMLcontrol which external-module type sets show up in the module menu (radio/src/gui/gui_common.cpp) — they're independent gates, not mutually exclusive, so exposing both as plain YES/NO toggles (matching thepxx1/ghost/etc. pattern from #149) is safe. Most colorlcd-family targets already defaultMODULE_SIZE_STD=ONvia a real CMakeoption(); this lets a build request explicitly turn that off and/or turnMODULE_SIZE_SMLon instead. As with the other flags, this is a puretargets.jsondata change — no Go/frontend code needed.Test plan
jq . targets.jsonvalidatesgo build ./...go test ./targets/... ./firmware/...passgo run ./cmd/ebuild run api):GET /api/targetsreturnsmodule_size_std/module_size_smlwith["YES","NO"]POST /api/jobsonx10expresswithmodule_size_std=NO+module_size_sml=YES→201, resolved tobuild_flags: [{"key":"MODULE_SIZE_SML","value":"YES"},{"key":"MODULE_SIZE_STD","value":"NO"}]🤖 Generated with Claude Code