Skip to content

Add module size override flags - #150

Open
pfeerick wants to merge 1 commit into
masterfrom
78-module-size-flags
Open

Add module size override flags#150
pfeerick wants to merge 1 commit into
masterfrom
78-module-size-flags

Conversation

@pfeerick

@pfeerick pfeerick commented Sep 2, 2026

Copy link
Copy Markdown
Member

Summary

MODULE_SIZE_STD/MODULE_SIZE_SML control which external-module type sets show up in the module menu (radio/src/gui/gui_common.cpp) — they're independent gates, not mutually exclusive, so exposing both as plain YES/NO toggles (matching the pxx1/ghost/etc. pattern from #149) is safe. Most colorlcd-family targets already default MODULE_SIZE_STD=ON via a real CMake option(); this lets a build request explicitly turn that off and/or turn MODULE_SIZE_SML on instead. As with the other flags, this is a pure targets.json data change — no Go/frontend code needed.

Test plan

  • jq . targets.json validates
  • go build ./...
  • go test ./targets/... ./firmware/... pass
  • Ran the real API server locally (Postgres in Docker + go run ./cmd/ebuild run api):
    • GET /api/targets returns module_size_std/module_size_sml with ["YES","NO"]
    • POST /api/jobs on x10express with module_size_std=NO + module_size_sml=YES201, resolved to build_flags: [{"key":"MODULE_SIZE_SML","value":"YES"},{"key":"MODULE_SIZE_STD","value":"NO"}]

🤖 Generated with Claude Code

Adds global module_size_std and module_size_sml flags mapping to
-DMODULE_SIZE_STD=<value> / -DMODULE_SIZE_SML=<value>, letting a build
request override the external module bay size EdgeTX compiles for
(the two macros are independent gates on which module types appear in
the menu, not mutually exclusive, so both can be toggled freely) (#78).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add module size override flags

1 participant