Repository navigation
Conversation
There was a problem hiding this comment.
If your organization's extra usage balance is empty, an organization admin can add extra usage credits at claude.ai/admin-settings/usage. If its monthly spend limit was reached, an admin can raise it on the same page. If neither applies, contact Anthropic support.
Once extra usage is available, someone with write access to this repository can comment @claude review on this pull request to trigger a review.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 28 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Closes #1863
Claimant: antigravity:0bf51a92-7798-4214-9d8f-7dc9804217b4
Summary
Implements Package 8A Feature F1 (30-day EU Omnibus prior price-floor check and 90-day Buy-Now vs Wait cycle indicator) across
rate.vnproduct price history,/inspect, and/dealswith zero database migrations and zero LLM/runtime infrastructure cost:Pure 30-Day EU Prior Floor & 90-Day Percentile Engine (
apps/web/src/lib/omnibus-price-audit.ts)priorFloorPriceVnd, exact VND and percentage deltas vs the prior floor, and seller strikethrough markup vs the prior floor.omnibus_30d_certified) ONLY when actual observed history (seriesLatestMs - earliestMsandanchorMs - earliestMs) spans>= 30full days across>= 3distinct observation days with zero blackout gaps (> 18days). Shorter windows (< 30days) report exact observed days (partial_window) and gapped logs (blackout_gap) withhold certification without fabricating day counts.>= 5distinct observed days spanning>= 14days,>= 1%relative range) to classifybuy_now_floor(<= P15),fair_market(P16..P70), orabove_recent_floor(> P70, reporting exact VND gap above the 90-day low).implausiblyLow,< MINIMUM_DEVICE_PRICE_FLOOR_VND/< MINIMUM_EARBUDS_PRICE_FLOOR_VND),out_of_stock/discontinued, and syntheticlive_listingrows.Three UI Surfaces (
PriceHistorySection.tsx,DeepInspectWorkspace.tsx,DealFinderWorkspace.tsx)PriceHistorySection.tsx, adapting between product-wide verified floor and per-merchant filter selection) and/inspect(DeepInspectWorkspace.tsx, evaluating matched listings strictly against their own 30-day history and the 90-day market cycle at the listing's own price, with WCAG 3.1.2langtagging on seller names).All devices,Top genuine sale drops,Pre-sale inflated strikethrough alerts) and per-card callouts on/deals(DealFinderWorkspace.tsx), preserving keyboard focus on empty-state resets.Localization & Accessibility (
vi,en,cs)vi,en, andcsstrictly inside"deals","inspect", and"priceVerdict"namespaces, using plain shopper sentence-case copy, CzechNBSP/ decimal comma formatting, zero em/en-dashes, and WCAG 2.1 AA contrast (>= 4.5:1) in both light and dark themes.Review Gate
/inspectmatched-listing 90d cycle price & 0-history listing scoping,PriceHistorySectionunavailable-offer & peer-reference propagation,seriesSpanMstrailing-silence window honesty, non-earbuds1,200,000 VNDfloor propagation,blackout_gapwindowDaysUsed = 0, 90d< 1%micro-spread guard + live low clamping, sub-0.05%2-decimal rounding without-0%/+0%, andmatchesSeasonalSaleFilterstrictpriceOriginal > priceCurrent/savingsVsMedianVnd > 0checks). All 8 findings fixed and covered by unit regression tests.>= 4.97:1across all token pairs), heading hierarchy (h1 -> h2 -> h3), ARIA group/pressed semantics, and strict file/namespace partition. Found 3 P2 + 2 P3 findings (blackout_gapper-offer badge guard,<ContentText>lang="vi"wrapper on/inspectseller name,focusCardIndexrestoration on/dealscampaign reset, double-negativesave {savings}& CzechNBSPbeforedpolish). All 5 findings fixed and verified./codex:reviewcould not run locally in this session.Verification
pnpm --filter @repo/web test(all suites includingcore-rate-architecture,display-truth,discount-verdict-copy,sale-state,offer-plausibility,client-messages,plural-copy) - PASSpnpm typecheck- PASSpnpm lint(--max-warnings 0) - PASSpnpm build- PASS📌 TL;DR
This PR introduces a "Seasonal Sale Campaign" filter to the Deal Finder and a comprehensive "Omnibus Price Audit" card to the Deep Inspect workspace. These features leverage 30-day EU price-floor rules and 90-day market cycles to distinguish genuine discounts from inflated "fake sale" traps, with full localization support for English, Czech, and Vietnamese.
🎯 Type of Change
🔍 Changes Walkthrough
apps/web/locales/cs.jsonapps/web/locales/en.jsonapps/web/locales/vi.jsonapps/web/src/components/deals/DealFinderWorkspace.tsxapps/web/src/components/inspect/DeepInspectWorkspace.tsxevaluateOmnibusPriceAuditlogic to calculate 30-day EU floors and 90-day cycles. Rendered a new 3-column audit card displaying current price vs. claimed price, verified floor status, and buy/wait recommendations.📊 Architectural Flow
flowchart TD subgraph Data Layer A[Price History Points] --> B[Omnibus Price Audit Lib] C[Current Offer Data] --> B end subgraph Deal Finder D[DealFinderWorkspace] --> E{Seasonal Filter Mode} E -->|All| F[Show All Deals] E -->|Genuine| G[Filter Genuine Drops] E -->|Traps| H[Filter Inflated Traps] G --> I[Render Genuine Callouts] H --> J[Render Trap Callouts] end subgraph Deep Inspect K[DeepInspectWorkspace] --> L[Calculate 30d EU Floor] K --> M[Calculate 90d Cycle] L --> N[Omnibus Audit Card] M --> N N --> O[Col 1: Current vs Claimed] N --> P[Col 2: Verified Floor Status] N --> Q[Col 3: Buy Now vs Wait] end