Skip to content

fix(importer): remove unsourced seed templates and tighten 1758 test - #1858

Merged
JOY (JOY) merged 2 commits into
devfrom
fix/1855-seed-template-cleanup
Nov 22, 2026
Merged

JOY (JOY) merged 2 commits into
devfrom
fix/1855-seed-template-cleanup

Conversation

@JOY

@JOY JOY (JOY) commented Nov 22, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • 2026 seeds & normalizer (#1803 item 6): Replace unsourced "6.0, A2DP, LE" Bluetooth template strings with exact cited official values ("6" on apple:iphone-18-pro-max:256gb and apple:iphone-18-pro:256gb citing https://www.apple.com/iphone-18-pro/specs/; "6.0" on samsung:galaxy-s26-ultra:256gb citing https://www.samsungmobilepress.com/media-assets/galaxy-s26-ultra?tab=specs) in both flagship-seed-sourced-2026.ts and product-normalizer.ts.
  • Sourced Apple 5G band lists, Bluetooth & canonical model numbers:
    • Replace unsourced 5G band descriptions on apple:ipad-pro-m5-11:256gb and apple:watch-ultra-3-49mm:64gb with official Apple Tech Specs NR band lists and field-level sources['cellular.bands_5g'].
    • Replace unsourced "5.3, AAC, Ultra-low latency..." Bluetooth codec text on apple:airpods-pro-2-usbc:64gb with "5.3" citing https://support.apple.com/en-us/111836.
    • Replace unsourced CE/FCC/QCVN strings on the 3 CANONICAL_BACKFILL_SPECS_BY_MODEL_KEY entries (iphone-16, iphone-16-plus, iphone-15) with sourced Apple Vietnam/global model numbers (A3287, A3290, A3090) so canonicalMasterUpdate overwrites stale stored values on merge.
  • Remaining unsourced seed template & cross-category fields (flagship-seed-data.ts): Drop remaining unsourced x.y, <profile> Bluetooth profile strings (12 seeds), unsourced CE/FCC/QCVN* regulatory strings (25 seeds), laptop rear-camera placeholders and non-webcam port/mic text (all 5 laptop seeds, keeping front webcams), and Wi-Fi-only / non-cellular cellular.* guesses (technology, sim_type, volte, vowifi on Wi-Fi-only tablets, laptops, and GPS watches), recording every removed seed path in retract_spec_fields (84/84 deleted paths across 27 seeds).
  • Close group-level sources.<group> loophole (seed-template-values-1758.test.ts): Require explicit field-level sources[path] for template-shaped and cross-category assertions, add negative regression tests proving group-level citations cannot mask them, and assert seedMasterSpecUpdate + canonicalMasterUpdate + ProductSpecificationsSchema + 10-group + rear-camera audit invariants.
  • Zero Production database writes: Code, seed definitions, and unit tests in DOS/Rate only.

Verification & Review Gate

  • pnpm --filter @repo/crawlers test (all 30 test suites pass)
  • pnpm --filter @repo/crawlers test:dist
  • pnpm typecheck, pnpm lint, pnpm build
  • Fresh-context Review Gate (Round 1 complete): Ran 2 independent research subagent reviewers on git diff origin/dev...HEAD (Provenance & Data-Truth Reviewer: 3 P1 + 1 P2; Schema & Retraction Reviewer: 1 P1 + 1 P2 + 1 P3) and fixed all findings in cd59a1aa.
  • Codex CLI note: Local Codex CLI (codex@openai-codex) is out of quota until Nov 25, 2026 and did not run.

Closes #1855

Claimant: antigravity:080b13ff-7d20-4e09-a474-cb187fc2b9da

- Replace unsourced "6.0, A2DP, LE" Bluetooth text on iPhone 18 Pro,
  iPhone 18 Pro Max, and Galaxy S26 Ultra with sourced versions ("6"
  and "6.0") in flagship-seed-sourced-2026.ts and product-normalizer.ts
  (#1803 item 6).
- Replace unsourced 5G band labels on iPad Pro M5 and Apple Watch Ultra 3
  with official Apple NR band lists and field-level sources.
- Drop remaining unsourced Bluetooth profile strings, CE/FCC/QCVN
  certifications, and cross-category laptop camera and Wi-Fi-only
  cellular placeholders across flagship-seed-data.ts, recording every
  removed seed field in retract_spec_fields.
- Require field-level sources[path] in seed-template-values-1758.test.ts
  so group-level sources.<group> cannot mask template or placeholder
  values (#1855).

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped — your organization has no extra usage available to pay for this review.

If your organization's extra usage balance is empty, an organization admin can add extra usage credits at claude.ai/admin-settings/usage. If its monthly spend limit was reached, an admin can raise it on the same page. If neither applies, contact Anthropic support.

Once extra usage is available, someone with write access to this repository can comment @claude review on this pull request to trigger a review.

@vercel

vercel Bot commented Nov 22, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
rate Ready Ready Preview Nov 22, 2026 10:44am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Nov 22, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 18 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 173de7ff-3ed4-4460-8013-b1d191b5da50
Commits

Reviewing files that changed from the base of the PR and between 64bbf72 and cd59a1a.

Files selected for processing: 7

  • apps/importer/src/shopee/__tests__/seed-earbuds-gpu-1793.test.ts
  • apps/importer/src/shopee/__tests__/seed-template-values-1758.test.ts
  • apps/importer/src/shopee/__tests__/sourced-seeds.test.ts
  • apps/importer/src/shopee/flagship-seed-data.ts
  • apps/importer/src/shopee/flagship-seed-sourced-2026.ts
  • apps/importer/src/shopee/product-normalizer.ts
  • apps/importer/src/shopee/test-ai-enricher.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

dos[bot]
dos Bot approved these changes Nov 22, 2026

@dos dos Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⏱️ Code Review completed (7 eligible files · 65,158 chars · 3 model call(s) · 3 PR unit(s))

Whole diff with bounded context at base 64bbf72 / head 9a60a88.

✅ CLEAN_PASS: Complete diff reviewed

Context investigation was bounded to the explicitly requested snapshot paths.

- Replace unsourced certifications on the 3 canonical iPhone entries
  with sourced Apple Vietnam model identifiers (A3287, A3290, A3090)
  so canonicalMasterUpdate overwrites stale stored values (#1855).
- Replace AirPods Pro 2 USB-C Bluetooth codec string with sourced "5.3"
  citing Apple Tech Specs, and remove port/mic text from MacBook key
  camera specs.
- Broaden Bluetooth profile, QCVN, 5G band-pair, and mid-string
  non-cellular regexes in seed-template-values-1758.test.ts, extend
  checks to watches/earbuds, and verify 10-group + rear-camera audit
  invariants after retraction.
dos[bot]
dos Bot approved these changes Nov 22, 2026

@dos dos Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⏱️ Code Review completed (7 eligible files · 74,204 chars · 1 model call(s) · 3 PR unit(s))

Whole diff with bounded context at base 64bbf72 / head cd59a1a.

✅ CLEAN_PASS: Complete diff reviewed

@JOY

Copy link
Copy Markdown
Contributor Author

PO acceptance: merge at cd59a1a

@JOY
JOY (JOY) merged commit 7e6a3ac into dev Nov 22, 2026
18 checks passed
@JOY
JOY (JOY) deleted the fix/1855-seed-template-cleanup branch November 22, 2026 10:55
@JOY JOY (JOY) mentioned this pull request Nov 22, 2026
2 of 6 tasks

This branch was successfully deployed

1 active deployment
Preview — cd59a1aa Deployed Nov 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(importer): remove remaining unsourced template seed fields and tighten 1758 test

1 participant