Repository navigation
fix(importer): remove unsourced seed templates and tighten 1758 test - #1858
Conversation
- Replace unsourced "6.0, A2DP, LE" Bluetooth text on iPhone 18 Pro,
iPhone 18 Pro Max, and Galaxy S26 Ultra with sourced versions ("6"
and "6.0") in flagship-seed-sourced-2026.ts and product-normalizer.ts
(#1803 item 6).
- Replace unsourced 5G band labels on iPad Pro M5 and Apple Watch Ultra 3
with official Apple NR band lists and field-level sources.
- Drop remaining unsourced Bluetooth profile strings, CE/FCC/QCVN
certifications, and cross-category laptop camera and Wi-Fi-only
cellular placeholders across flagship-seed-data.ts, recording every
removed seed field in retract_spec_fields.
- Require field-level sources[path] in seed-template-values-1758.test.ts
so group-level sources.<group> cannot mask template or placeholder
values (#1855).
There was a problem hiding this comment.
If your organization's extra usage balance is empty, an organization admin can add extra usage credits at claude.ai/admin-settings/usage. If its monthly spend limit was reached, an admin can raise it on the same page. If neither applies, contact Anthropic support.
Once extra usage is available, someone with write access to this repository can comment @claude review on this pull request to trigger a review.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 18 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
- Replace unsourced certifications on the 3 canonical iPhone entries with sourced Apple Vietnam model identifiers (A3287, A3290, A3090) so canonicalMasterUpdate overwrites stale stored values (#1855). - Replace AirPods Pro 2 USB-C Bluetooth codec string with sourced "5.3" citing Apple Tech Specs, and remove port/mic text from MacBook key camera specs. - Broaden Bluetooth profile, QCVN, 5G band-pair, and mid-string non-cellular regexes in seed-template-values-1758.test.ts, extend checks to watches/earbuds, and verify 10-group + rear-camera audit invariants after retraction.
|
PO acceptance: merge at cd59a1a |
Summary
#1803item 6): Replace unsourced"6.0, A2DP, LE"Bluetooth template strings with exact cited official values ("6"onapple:iphone-18-pro-max:256gbandapple:iphone-18-pro:256gbcitinghttps://www.apple.com/iphone-18-pro/specs/;"6.0"onsamsung:galaxy-s26-ultra:256gbcitinghttps://www.samsungmobilepress.com/media-assets/galaxy-s26-ultra?tab=specs) in bothflagship-seed-sourced-2026.tsandproduct-normalizer.ts.apple:ipad-pro-m5-11:256gbandapple:watch-ultra-3-49mm:64gbwith official Apple Tech Specs NR band lists and field-levelsources['cellular.bands_5g']."5.3, AAC, Ultra-low latency..."Bluetooth codec text onapple:airpods-pro-2-usbc:64gbwith"5.3"citinghttps://support.apple.com/en-us/111836.CE/FCC/QCVNstrings on the 3CANONICAL_BACKFILL_SPECS_BY_MODEL_KEYentries (iphone-16,iphone-16-plus,iphone-15) with sourced Apple Vietnam/global model numbers (A3287,A3290,A3090) socanonicalMasterUpdateoverwrites stale stored values on merge.flagship-seed-data.ts): Drop remaining unsourcedx.y, <profile>Bluetooth profile strings (12 seeds), unsourcedCE/FCC/QCVN*regulatory strings (25 seeds), laptop rear-camera placeholders and non-webcam port/mic text (all 5 laptop seeds, keeping front webcams), and Wi-Fi-only / non-cellularcellular.*guesses (technology,sim_type,volte,vowifion Wi-Fi-only tablets, laptops, and GPS watches), recording every removed seed path inretract_spec_fields(84/84 deleted paths across 27 seeds).sources.<group>loophole (seed-template-values-1758.test.ts): Require explicit field-levelsources[path]for template-shaped and cross-category assertions, add negative regression tests proving group-level citations cannot mask them, and assertseedMasterSpecUpdate+canonicalMasterUpdate+ProductSpecificationsSchema+ 10-group + rear-camera audit invariants.DOS/Rateonly.Verification & Review Gate
pnpm --filter @repo/crawlers test(all 30 test suites pass)pnpm --filter @repo/crawlers test:distpnpm typecheck,pnpm lint,pnpm buildresearchsubagent reviewers ongit diff origin/dev...HEAD(Provenance & Data-Truth Reviewer: 3 P1 + 1 P2;Schema & Retraction Reviewer: 1 P1 + 1 P2 + 1 P3) and fixed all findings incd59a1aa.codex@openai-codex) is out of quota until Nov 25, 2026 and did not run.Closes #1855
Claimant: antigravity:080b13ff-7d20-4e09-a474-cb187fc2b9da