Skip to content

fix(importer): remove remaining unsourced template seed fields and tighten 1758 test #1855

Closed

Description

@JOY

Goal

Finish cleaning up unsourced GSM/catalog template spec values in @repo/crawlers flagship seed definitions and product-normalizer.ts (including follow-up item 6 from DOS/Rate#1803), record every dropped seed path in retract_spec_fields, and close the group-level citation loophole in seed-template-values-1758.test.ts (code and unit tests only - no Production DB writes).

Requirements

  1. DOS/Rate#1803 item 6 ("6.0, A2DP, LE" Bluetooth template string on 2026 seeds & normalizer):
    • In apps/importer/src/shopee/flagship-seed-sourced-2026.ts (lines 105, 258, 418) and apps/importer/src/shopee/product-normalizer.ts (lines 1496, 1561, 1628), apple:iphone-18-pro-max:256gb, apple:iphone-18-pro:256gb, and samsung:galaxy-s26-ultra:256gb still carry "6.0, A2DP, LE" even though the cited Apple/Samsung spec pages do not state A2DP, LE (Apple states Bluetooth 6; verify Samsung official spec citation or retract if uncited).
    • Replace with the exact value stated on the cited official source (with field-level source citation where applicable) or drop and list "connectivity.bluetooth" in retract_spec_fields when uncited.
  2. Close the group-level sources loophole in seed-template-values-1758.test.ts:
    • Currently cites(entry, path) (lines 49-50) accepts a group-level entry.sources?.[group], which allowed sources.connectivity on flagship-seed-sourced-2026.ts to mask an unsourced "6.0, A2DP, LE" template string.
    • Tighten seed-template-values-1758.test.ts so template-shaped strings (BLUETOOTH_PROFILES, CERT_CODES, SA/NSA/Sub6, cross-category placeholders) require explicit field-level entry.sources?.[path] (or are absent and listed in retract_spec_fields when retracted from an already-seeded device).
  3. Audit & retract remaining unsourced template fields in flagship-seed-data.ts:
    • Remove remaining unsourced x.y, A2DP, ... Bluetooth profile strings, unsourced CE, ... QCVN* regulatory strings, unsourced SA/NSA/Sub6 strings without band numbers, and cross-category placeholders (such as laptop camera.rear_setup / camera.second_camera "None" or Wi-Fi-only tablet/laptop connectivity.cellular "No" / "None" where not backed by a field-level source), adding every removed dotted path to that seed entrys retract_spec_fields array so future seedMasterSpecUpdate runs retract stale stored values instead of preserving them on merge.
  4. Stop-line: Code, seed definitions, and unit tests in DOS/Rate ONLY. Do NOT run backfill-specs --apply or any write against Production Supabase (gulptwduchsjcsbndmua).

Approach

Inspect flagship-seed-sourced-2026.ts, flagship-seed-data.ts, product-normalizer.ts, and seed-template-values-1758.test.ts alongside the #1784-#1801 retraction pattern, update the seed entries + retract_spec_fields + normalizer registry entries, and strengthen seed-template-values-1758.test.ts so all 23+ flagship seeds pass strict provenance checks.

Acceptance

  • Zero unsourced x.y, A2DP, ..., CE/FCC/QCVN*, SA/NSA/Sub6, or cross-category placeholder strings remain across FLAGSHIP_DEVICES_TO_SEED (flagship-seed-data.ts + flagship-seed-sourced-2026.ts) and product-normalizer.ts (iphone-18-pro, iphone-18-pro-max, galaxy-s26-ultra).
  • Every spec field removed from an existing seed entry is listed in its retract_spec_fields and verified by seedMasterSpecUpdate retraction tests.
  • seed-template-values-1758.test.ts no longer allows group-level sources.<group> to excuse template-shaped field values without a field-level sources[path].
  • All @repo/crawlers and monorepo tests, lint, and typecheck pass with zero Production database writes.

Files

  • apps/importer/src/shopee/flagship-seed-sourced-2026.ts
  • apps/importer/src/shopee/flagship-seed-data.ts
  • apps/importer/src/shopee/product-normalizer.ts
  • apps/importer/src/shopee/__tests__/seed-template-values-1758.test.ts

Activity

  1. added
    bugSomething isn't working
    status:readyTask ready to be picked up by an Agent
    po:antigravityDispatched by the Antigravity Product Owner
    on Nov 22, 2026
  2. added theissue type on Nov 22, 2026
  3. JOY commented on Nov 22, 2026

    @JOY
    ContributorAuthor

    🔒 [Agent: Crawl] Claim lock refs/claims/1855 taken by claimant antigravity:080b13ff-7d20-4e09-a474-cb187fc2b9da (Status: in-progress).

  4. added
    status:in-progressTask currently claimed and being worked on by an Agent
    agent:crawlClaimed by Agent: Crawl
    and removed
    status:readyTask ready to be picked up by an Agent
    on Nov 22, 2026
  5. self-assigned this
    on Nov 22, 2026
  6. JOY commented on Nov 22, 2026

    @JOY
    ContributorAuthor

    [Agent: Crawl] Claimed this issue on branch fix/1855-seed-template-cleanup (claimant antigravity:080b13ff-7d20-4e09-a474-cb187fc2b9da). Auditing flagship-seed-sourced-2026.ts, flagship-seed-data.ts, product-normalizer.ts, and tightening seed-template-values-1758.test.ts (zero Production DB writes).

  7. added
    status:in-reviewTask completed and waiting for review / PR merge
    and removed
    status:in-progressTask currently claimed and being worked on by an Agent
    on Nov 22, 2026
  8. JOY commented on Nov 22, 2026

    @JOY
    ContributorAuthor

    [Agent: Crawl] Opened PR #1858 (fix/1855-seed-template-cleanup -> dev), moved status to in-review, and launched 2 independent fresh-context research subagent reviews alongside CI.

  9. JOY commented on Nov 22, 2026

    @JOY
    ContributorAuthor

    🔓 [Agent: Crawl] Claim lock refs/claims/1855 of antigravity:080b13ff-7d20-4e09-a474-cb187fc2b9da (Agent Crawl) since 2026-11-22T09:48:44Z released by claimant antigravity:def296a6-5f67-48da-bb74-ee3ede4b7061 because #1855 is closed (Status: done).

  10. added
    status:doneTask completed and verified
    and removed
    status:in-reviewTask completed and waiting for review / PR merge
    on Nov 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

agent:crawlClaimed by Agent: Crawlarea:crawlersbugSomething isn't workingpo:antigravityDispatched by the Antigravity Product Ownerstatus:doneTask completed and verified

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions