Repository navigation
Closed
Copy link
Labels
agent:crawlClaimed by Agent: CrawlClaimed by Agent: Crawlarea:crawlersbugSomething isn't workingSomething isn't workingpo:antigravityDispatched by the Antigravity Product OwnerDispatched by the Antigravity Product Ownerstatus:doneTask completed and verifiedTask completed and verified
Description
Goal
Finish cleaning up unsourced GSM/catalog template spec values in @repo/crawlers flagship seed definitions and product-normalizer.ts (including follow-up item 6 from DOS/Rate#1803), record every dropped seed path in retract_spec_fields, and close the group-level citation loophole in seed-template-values-1758.test.ts (code and unit tests only - no Production DB writes).
Requirements
DOS/Rate#1803item 6 ("6.0, A2DP, LE"Bluetooth template string on 2026 seeds & normalizer):- In
apps/importer/src/shopee/flagship-seed-sourced-2026.ts(lines 105, 258, 418) andapps/importer/src/shopee/product-normalizer.ts(lines 1496, 1561, 1628),apple:iphone-18-pro-max:256gb,apple:iphone-18-pro:256gb, andsamsung:galaxy-s26-ultra:256gbstill carry"6.0, A2DP, LE"even though the cited Apple/Samsung spec pages do not stateA2DP, LE(Apple states Bluetooth6; verify Samsung official spec citation or retract if uncited). - Replace with the exact value stated on the cited official source (with field-level source citation where applicable) or drop and list
"connectivity.bluetooth"inretract_spec_fieldswhen uncited.
- In
- Close the group-level
sourcesloophole inseed-template-values-1758.test.ts:- Currently
cites(entry, path)(lines 49-50) accepts a group-levelentry.sources?.[group], which allowedsources.connectivityonflagship-seed-sourced-2026.tsto mask an unsourced"6.0, A2DP, LE"template string. - Tighten
seed-template-values-1758.test.tsso template-shaped strings (BLUETOOTH_PROFILES,CERT_CODES,SA/NSA/Sub6, cross-category placeholders) require explicit field-levelentry.sources?.[path](or are absent and listed inretract_spec_fieldswhen retracted from an already-seeded device).
- Currently
- Audit & retract remaining unsourced template fields in
flagship-seed-data.ts:- Remove remaining unsourced
x.y, A2DP, ...Bluetooth profile strings, unsourcedCE, ... QCVN*regulatory strings, unsourcedSA/NSA/Sub6strings without band numbers, and cross-category placeholders (such as laptopcamera.rear_setup/camera.second_camera"None"or Wi-Fi-only tablet/laptopconnectivity.cellular"No"/"None"where not backed by a field-level source), adding every removed dotted path to that seed entrysretract_spec_fieldsarray so futureseedMasterSpecUpdateruns retract stale stored values instead of preserving them on merge.
- Remove remaining unsourced
- Stop-line: Code, seed definitions, and unit tests in
DOS/RateONLY. Do NOT runbackfill-specs --applyor any write against Production Supabase (gulptwduchsjcsbndmua).
Approach
Inspect flagship-seed-sourced-2026.ts, flagship-seed-data.ts, product-normalizer.ts, and seed-template-values-1758.test.ts alongside the #1784-#1801 retraction pattern, update the seed entries + retract_spec_fields + normalizer registry entries, and strengthen seed-template-values-1758.test.ts so all 23+ flagship seeds pass strict provenance checks.
Acceptance
- Zero unsourced
x.y, A2DP, ...,CE/FCC/QCVN*,SA/NSA/Sub6, or cross-category placeholder strings remain acrossFLAGSHIP_DEVICES_TO_SEED(flagship-seed-data.ts+flagship-seed-sourced-2026.ts) andproduct-normalizer.ts(iphone-18-pro,iphone-18-pro-max,galaxy-s26-ultra). - Every spec field removed from an existing seed entry is listed in its
retract_spec_fieldsand verified byseedMasterSpecUpdateretraction tests. seed-template-values-1758.test.tsno longer allows group-levelsources.<group>to excuse template-shaped field values without a field-levelsources[path].- All
@repo/crawlersand monorepo tests, lint, and typecheck pass with zero Production database writes.
Files
apps/importer/src/shopee/flagship-seed-sourced-2026.tsapps/importer/src/shopee/flagship-seed-data.tsapps/importer/src/shopee/product-normalizer.tsapps/importer/src/shopee/__tests__/seed-template-values-1758.test.ts
Metadata
Metadata
Assignees
Labels
agent:crawlClaimed by Agent: CrawlClaimed by Agent: Crawlarea:crawlersbugSomething isn't workingSomething isn't workingpo:antigravityDispatched by the Antigravity Product OwnerDispatched by the Antigravity Product Ownerstatus:doneTask completed and verifiedTask completed and verified
Activity
JOY commentedon Nov 22, 2026
🔒 [Agent: Crawl] Claim lock
refs/claims/1855taken by claimantantigravity:080b13ff-7d20-4e09-a474-cb187fc2b9da(Status: in-progress).JOY commentedon Nov 22, 2026
[Agent: Crawl] Claimed this issue on branch
fix/1855-seed-template-cleanup(claimantantigravity:080b13ff-7d20-4e09-a474-cb187fc2b9da). Auditingflagship-seed-sourced-2026.ts,flagship-seed-data.ts,product-normalizer.ts, and tighteningseed-template-values-1758.test.ts(zero Production DB writes).JOY commentedon Nov 22, 2026
[Agent: Crawl] Opened PR #1858 (
fix/1855-seed-template-cleanup->dev), moved status toin-review, and launched 2 independent fresh-contextresearchsubagent reviews alongside CI.fix(importer): address round 1 provenance and retraction review
fix(importer): remove unsourced seed templates and tighten 1758 test (#…
JOY commentedon Nov 22, 2026
🔓 [Agent: Crawl] Claim lock
refs/claims/1855of antigravity:080b13ff-7d20-4e09-a474-cb187fc2b9da (Agent Crawl) since 2026-11-22T09:48:44Z released by claimantantigravity:def296a6-5f67-48da-bb74-ee3ede4b7061because #1855 is closed (Status: done).