Skip to content

build(deps): bump schemars from 0.8.22 to 1.2.2 #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dependabot wants to merge 1 commit into
base: main
Choose a base branch
from
+30 −9
Open

build(deps): bump schemars from 0.8.22 to 1.2.2 #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 29 additions & 8 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ starlark = "0.13"

# CLI - MCP
rmcp = { version = "0.13", default-features = false }
schemars = "0.8"
schemars = "1.2"

@greptile-apps greptile-apps Bot Sep 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Migrate schema implementation

This change selects schemars 1.2, but ConversationId still uses the removed 0.8 r#gen and schema APIs and the former schema_name() signature. The direct workspace consumer build now stops in cortex-protocol, so the CLI, app server, and other dependent packages cannot be built until that implementation is migrated to the schemars 1.x public API.

Artifacts

Evidence from the check

  • Authored script that runs the prescribed three-package Cargo check against the parent of the schemars upgrade, establishing the matching baseline.

Command output from the check

  • Complete output from the prescribed narrow Cargo check at the parent revision, ending successfully with `EXIT_CODE: 0`; the baseline compiles.

Evidence from the check

  • Authored script that runs the prescribed three-package Cargo check in the supplied upgraded workspace.

Command output from the check

  • Complete output from the prescribed narrow Cargo check after the schemars 1.2.2 upgrade, ending with `EXIT_CODE: 101` and the incompatible `ConversationId` schemars errors; the upgrade blocks compilation.

Evidence from the check

  • The authored Bash validation script reads the parent and current manifests, lockfile, and generated-contract documentation without changing repository source files; it provides the repeatable version comparison.

Command output from the check

  • The executed parent-revision comparison shows dependency constraint 0.8 and documented version 0.8.22, confirming the baseline documentation matched the prior dependency family.

Command output from the check

  • The executed validation script shows the current dependency constraint is 1.2, lockfile resolution is 1.2.2, and documentation remains 0.8.22; the takeaway is that the supplied finding is confirmed.

View artifacts

T-Rex Ran code and verified through T-Rex

@greptile-apps greptile-apps Bot Sep 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Update contract documentation

The generated-contract reference still says its OpenAPI contract uses schemars 0.8.22, while this change resolves schemars 1.2.2. This is a non-blocking documentation mismatch that can mislead maintainers about the generator used for the published contract.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Artifacts

Evidence from the check

  • Authored script that runs the prescribed three-package Cargo check against the parent of the schemars upgrade, establishing the matching baseline.

Command output from the check

  • Complete output from the prescribed narrow Cargo check at the parent revision, ending successfully with `EXIT_CODE: 0`; the baseline compiles.

Evidence from the check

  • Authored script that runs the prescribed three-package Cargo check in the supplied upgraded workspace.

Command output from the check

  • Complete output from the prescribed narrow Cargo check after the schemars 1.2.2 upgrade, ending with `EXIT_CODE: 101` and the incompatible `ConversationId` schemars errors; the upgrade blocks compilation.

Evidence from the check

  • The authored Bash validation script reads the parent and current manifests, lockfile, and generated-contract documentation without changing repository source files; it provides the repeatable version comparison.

Command output from the check

  • The executed parent-revision comparison shows dependency constraint 0.8 and documented version 0.8.22, confirming the baseline documentation matched the prior dependency family.

Command output from the check

  • The executed validation script shows the current dependency constraint is 1.2, lockfile resolution is 1.2.2, and documentation remains 0.8.22; the takeaway is that the supplied finding is confirmed.

View artifacts

T-Rex Ran code and verified through T-Rex


# CLI - Utilities
time = { version = "0.3", features = ["formatting", "parsing", "local-offset", "macros"] }
Expand Down
Loading