build(deps): bump schemars from 0.8.22 to 1.2.2 - #59
Conversation
Bumps [schemars](https://github.com/GREsau/schemars) from 0.8.22 to 1.2.2. - [Release notes](https://github.com/GREsau/schemars/releases) - [Changelog](https://github.com/GREsau/schemars/blob/master/CHANGELOG.md) - [Commits](GREsau/schemars@v0.8.22...v1.2.2) --- updated-dependencies: - dependency-name: schemars dependency-version: 1.2.2 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Greptile SummarySummary
The compilation failure must be resolved before merging. The documentation mismatch is non-blocking. Confidence Score: 4/5Not safe to merge until the manual schema implementation is migrated, because the affected workspace packages do not compile. A before-and-after compilation check established that the dependency update introduces a reproducible build failure. A separate version comparison also confirmed the documentation mismatch. Files Needing Attention:
What T-Rex did
|
| # CLI - MCP | ||
| rmcp = { version = "0.13", default-features = false } | ||
| schemars = "0.8" | ||
| schemars = "1.2" |
There was a problem hiding this comment.
This change selects schemars 1.2, but ConversationId still uses the removed 0.8 r#gen and schema APIs and the former schema_name() signature. The direct workspace consumer build now stops in cortex-protocol, so the CLI, app server, and other dependent packages cannot be built until that implementation is migrated to the schemars 1.x public API.
Artifacts
- Authored script that runs the prescribed three-package Cargo check against the parent of the schemars upgrade, establishing the matching baseline.
- Complete output from the prescribed narrow Cargo check at the parent revision, ending successfully with `EXIT_CODE: 0`; the baseline compiles.
- Authored script that runs the prescribed three-package Cargo check in the supplied upgraded workspace.
- Complete output from the prescribed narrow Cargo check after the schemars 1.2.2 upgrade, ending with `EXIT_CODE: 101` and the incompatible `ConversationId` schemars errors; the upgrade blocks compilation.
- The authored Bash validation script reads the parent and current manifests, lockfile, and generated-contract documentation without changing repository source files; it provides the repeatable version comparison.
- The executed parent-revision comparison shows dependency constraint 0.8 and documented version 0.8.22, confirming the baseline documentation matched the prior dependency family.
- The executed validation script shows the current dependency constraint is 1.2, lockfile resolution is 1.2.2, and documentation remains 0.8.22; the takeaway is that the supplied finding is confirmed.
| # CLI - MCP | ||
| rmcp = { version = "0.13", default-features = false } | ||
| schemars = "0.8" | ||
| schemars = "1.2" |
There was a problem hiding this comment.
The generated-contract reference still says its OpenAPI contract uses schemars 0.8.22, while this change resolves schemars 1.2.2. This is a non-blocking documentation mismatch that can mislead maintainers about the generator used for the published contract.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Artifacts
- Authored script that runs the prescribed three-package Cargo check against the parent of the schemars upgrade, establishing the matching baseline.
- Complete output from the prescribed narrow Cargo check at the parent revision, ending successfully with `EXIT_CODE: 0`; the baseline compiles.
- Authored script that runs the prescribed three-package Cargo check in the supplied upgraded workspace.
- Complete output from the prescribed narrow Cargo check after the schemars 1.2.2 upgrade, ending with `EXIT_CODE: 101` and the incompatible `ConversationId` schemars errors; the upgrade blocks compilation.
- The authored Bash validation script reads the parent and current manifests, lockfile, and generated-contract documentation without changing repository source files; it provides the repeatable version comparison.
- The executed parent-revision comparison shows dependency constraint 0.8 and documented version 0.8.22, confirming the baseline documentation matched the prior dependency family.
- The executed validation script shows the current dependency constraint is 1.2, lockfile resolution is 1.2.2, and documentation remains 0.8.22; the takeaway is that the supplied finding is confirmed.
Bumps schemars from 0.8.22 to 1.2.2.
Release notes
Sourced from schemars's releases.
... (truncated)
Changelog
Sourced from schemars's changelog.
... (truncated)
Commits
ed61863v1.2.2ae618c3Updatesynto v3 (#528)c072ea0docs: add missing attributes to table of contents (#517)015272fClippy fix (#512)944f727Bump bytes from 1.10.1 to 1.11.1 (#507)5ef5da1v1.2.14081b98Applyextend/transformattributes after any other attributes (#506)5bfec04v1.2.0f6b1f4cAddsmol_str03feature (#486)18826cdAdd test for changes from #452Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)