fix(accessibility): validate runtime text direction - #203
Closed
seonghobae wants to merge 3 commits into
Closed
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 11, 2026
This was referenced Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #230, which now owns the single
src/components/editorAccessibility.tswriter lane and preserves this PR's exact runtime-direction regression and implementation together with the subsequent ARIA and accessibility-metadata hardening.Historical exact evidence retained for traceability:
173c1c8b6165ccffd4d46abdf005e6aa7fe64cf9; CI31483115325failed the intended invalid-direction regression while Security31483115302and SAST31483115300passed.16d6a12f87bcf487102329b7ebbc5ca2b8652a56; CI31483603449, Security31483603300, and SAST31483603320passed.Issue #202 remains active through
Closes #202on #230; this PR is closed only to remove a competing writer for the same production path. No predecessor check/review evidence is transferred to #230.