Skip to content

fix(conversation): 미리보기 엔티티 복원 순서 수정 (CodeQL js/double-escaping) #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chanwoo7 merged 1 commit into from
Sep 2, 2026
Merged

fix(conversation): 미리보기 엔티티 복원 순서 수정 (CodeQL js/double-escaping) #278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/features/conversation/services/conversation-center-mappers.helper.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ describe('conversation-center-mappers.helper', () => {
'A & B <3>',
);
});

it('이중 이스케이프는 한 번만 복원한다(&amp;lt; → &lt;)', () => {
expect(stripHtmlToPreview('&amp;lt;b&amp;gt;')).toBe('&lt;b&gt;');
});
});

describe('toLastMessagePreview', () => {
Expand Down
20 changes: 12 additions & 8 deletions src/features/conversation/services/conversation-center-mappers.helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,18 @@
* 공백 정리로 충분하다(저장 원문은 그대로 유지).
*/
export function stripHtmlToPreview(html: string): string {
return html
.replace(/<[^>]*>/g, ' ')
.replace(/&nbsp;/g, ' ')
.replace(/&amp;/g, '&')
.replace(/&lt;/g, '<')
.replace(/&gt;/g, '>')
.replace(/\s+/g, ' ')
.trim();
return (
html
.replace(/<[^>]*>/g, ' ')
.replace(/&nbsp;/g, ' ')
.replace(/&lt;/g, '<')
.replace(/&gt;/g, '>')
// &amp; 복원은 반드시 마지막 — 먼저 풀면 "&amp;lt;" 같은 이중
// 이스케이프가 두 번 풀려 "<"가 된다 (CodeQL js/double-escaping)
.replace(/&amp;/g, '&')
.replace(/\s+/g, ' ')
.trim()
);
}

/** 마지막 메시지 row → 미리보기 텍스트. TEXT는 원문, HTML은 태그 제거. */
Expand Down
Loading