Skip to content

fix(conversation): 미리보기 엔티티 복원 순서 수정 (CodeQL js/double-escaping) - #278

Merged
chanwoo7 merged 1 commit into
developfrom
fix/codeql-double-escaping
Sep 2, 2026
Merged

fix(conversation): 미리보기 엔티티 복원 순서 수정 (CodeQL js/double-escaping)#278
chanwoo7 merged 1 commit into
developfrom
fix/codeql-double-escaping

Conversation

@chanwoo7

@chanwoo7 chanwoo7 commented Sep 2, 2026

Copy link
Copy Markdown
Member

CodeQL 오픈 알럿 #7(js/double-escaping) 해소 — stripHtmlToPreview의 & 복원을 마지막으로 이동해 이중 이스케이프의 과복원 차단. 회귀 spec 추가. API 표면 변경 없음.

CodeQL 알럿 #7 해소: stripHtmlToPreview가 &를 </>보다 먼저
복원해 "&amp;lt;" 같은 이중 이스케이프 입력이 두 번 풀려 "<"가 되던
문제. &amp; 복원을 마지막으로 이동(단일 복원 보장) + 회귀 spec 추가.
미리보기는 plain text 표기라 실행 위험은 없었으나 표기 왜곡 해소.
@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 2a0d7620-c153-4667-9aef-e1e9e38e4f5b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

🧹 knip — dead-code 리포트

Unused dependencies (1)
Duplicate exports (1)
전체 리포트
Unused dependencies (1)
graphql-ws  package.json:63:6
Duplicate exports (1)
KEYWORD_RANK_SNAPSHOT_SIZE|MAX_POPULAR_KEYWORDS_LIMIT  src/features/search/constants/search.constants.ts

청소 후보(오탐 가능) · 기준 docs/guide/architecture-conventions.md

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

🩺 NestJS Doctor — 90/100 (Excellent)

진단 303건 (error 0).

Category error warning info
architecture 0 0 9
correctness 0 154 0
performance 0 24 17
schema 0 0 86
security 0 13 0
architecture / security 상위 항목
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal type 'IAuditLogRepository'.
  • warning security/security/no-exposed-env-vars: Direct 'process.env.NODE_ENV' access in 'AuthController'. Use ConfigService instead.
  • warning security/security/require-guards-on-endpoints: Endpoint 'start' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'callback' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'refresh' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'logout' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'sellerLogin' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'sellerRefresh' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'sellerLogout' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'devIssueToken' has no @UseGuards() at class or method level.
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal module '@/features/conversation/repositories/conversation.repository'.
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal type 'ConversationRepository'.
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal module '@/features/order/repositories/order.repository'.
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal type 'OrderRepository'.
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal module '@/features/product/repositories/product.repository'.

오탐 포함 가능 · 기준 docs/guide/architecture-conventions.md

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 97.68% 5895/6035
🟢 Branches 93.12% 2316/2487
🟢 Functions 96.44% 1165/1208
🟢 Lines 98.26% 5368/5463

Test suite run success

1869 tests passing in 225 suites.

Report generated by 🧪jest coverage report action from b352a4c

@chanwoo7
chanwoo7 merged commit 078f17d into develop Sep 2, 2026
11 checks passed
@chanwoo7
chanwoo7 deleted the fix/codeql-double-escaping branch September 2, 2026 23:38
@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant