Skip to content

chore(policy): pre-register fixture digest for #2905 test cleanup #2917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joeharris76 merged 1 commit into from
Oct 12, 2026
Merged

chore(policy): pre-register fixture digest for #2905 test cleanup #2917

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions quality/comment-policy.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37908,6 +37908,19 @@
"owner": "comment-cleanup-unit-tests-cli-scripts-rest",
"removal": "Remove when the test's subprocess input becomes a static literal or the executable-payload adapter can reconstruct it."
},
{
"path": "tests/unit/test_standardized_test_commands.py",
"symbol": "TestMakefileCommands.test_pr_preflight_fast_tests_creates_classifier_artifacts_when_absent",
"text": "unresolved executable source: make",
"payload": "sha256:ec98147fe1cc42ba021f5d8b6dc1359df9c93cad0014e20a3a538e0368d2fa6a",
"finding_kind": "payload-error",
"kind": "fixture",
"consumer": "tests/unit/test_standardized_test_commands.py",
"necessity": "Pre-registered for the #2905 cleanup, which removes the obsolete merge_group routing doc test from this file and changes its AST digest. Same fixture as above: the test starts a subprocess whose program (make) is assembled at runtime.",
"alternative": "Rewrite the subprocess input as a static literal the checker can parse; that changes the test and was not taken in the cleanup.",
"owner": "comment-cleanup-unit-tests-cli-scripts-rest",
"removal": "Remove when the test's subprocess input becomes a static literal or the executable-payload adapter can reconstruct it."
},
{
"path": "tests/unit/test_standardized_test_commands.py",
"symbol": "TestMakefileCommands.test_skill_integrity_preflight_selected_lane_failure_propagates",
Expand Down
Loading