Repository navigation
chore(policy): pre-register fixture digest for #2905 test cleanup - #2917
Merged
Merged
Conversation
Pre-registers the comment-policy fixture digest for tests/unit/test_standardized_test_commands.py as modified by #2905 (removal of the obsolete merge_group routing doc test). The digest-bound exception must be on the base before the source change lands.
![benchbox-oracle[bot]](https://avatars.githubusercontent.com/u/319264189?s=60&v=4){kind=small}
There was a problem hiding this comment.
oracle-verdict: success for 62c17c67cff0a895adb8126a29f8d83b7086fd58
This result supersedes those for earlier heads; their open review threads still apply.
Tier: low-medium (data-only or small single-area change).
Decision: SHIP.
Reviewer: muse (muse muse-spark-1.3-contributor, effort medium).
Single fixture addition pre-registers the existing make payload-error for its post-#2905 file AST digest. Transition mode honours only base exceptions so this entry is inert until it lands, matching the documented add-exception-before-source workflow. Distinct payload avoids duplicate-identity rejection, schema fields are complete, and no benchmark, validation, or gate logic is weakened.
Reviewers not available
- luna: absent (error)
joeharris76
enabled auto-merge (squash)
October 12, 2026 14:36
joeharris76
added a commit
that referenced
this pull request
Oct 12, 2026
The README no longer documents merge_group-era heavy-tier routing, so the test asserting the old language is obsolete. Removes it as part of the dead branch cleanup. Fixture digest pre-registered in #2917.
joeharris76
added a commit
that referenced
this pull request
Oct 12, 2026
* fix(ci): remove dead merge_group heavy-tier branch * fix(ci): drop stale merge_group routing doc test The README no longer documents merge_group-era heavy-tier routing, so the test asserting the old language is obsolete. Removes it as part of the dead branch cleanup. Fixture digest pre-registered in #2917. * fix(ci): keep routing ratchet; reword README, drop unused pre-registration Per oracle review: only one assertion of the medium-tier doc-routing test went stale, so the test is restored and the README reworded to keep the pinned heavy-tier phrase without merge_group. Removes the now-unused pre-registered fixture digest.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-registers the comment-policy fixture digest for tests/unit/test_standardized_test_commands.py as modified by #2905 (removal of the obsolete merge_group routing doc test). The digest-bound exception must be on the base before the source change lands.