Repository navigation
fix(ci): remove dead merge_group heavy-tier branch - #2905
Conversation
![benchbox-oracle[bot]](https://avatars.githubusercontent.com/u/319264189?s=60&v=4){kind=small}
There was a problem hiding this comment.
oracle-verdict: success for 0034da936f8b390596f3927af1c060f13e646051
This result supersedes those for earlier heads; their open review threads still apply.
Tier: medium-high (touches 2 areas).
Decision: SHIP.
Reviewer: muse (muse muse-spark-1.3-contributor, effort medium).
Removes dead merge_group carve-out: ci.yml triggers only on pull_request so github.event_name was always pull_request and the merge_group branch was unreachable. Reachable heavy-tier behavior, fail-closed handling, packaging and soundness carve-outs, trunk.yml full-tier coverage, and sole CLI caller are unchanged. No correctness, validation, gate-weakening, or security defect found.
Reviewers not available
- sol: absent (error)
- luna: absent (error)
) Pre-registers the comment-policy fixture digest for tests/unit/test_standardized_test_commands.py as modified by #2905 (removal of the obsolete merge_group routing doc test). The digest-bound exception must be on the base before the source change lands.
The README no longer documents merge_group-era heavy-tier routing, so the test asserting the old language is obsolete. Removes it as part of the dead branch cleanup. Fixture digest pre-registered in #2917.
0034da9 to
83d05fe
Compare
There was a problem hiding this comment.
oracle-verdict: failure for 83d05fe07a6e58c9b57d2383d7f5fcfbc33dbcfc
This result supersedes those for earlier heads; their open review threads still apply.
Tier: medium-high (touches 2 areas).
Decision: SHIP WITH FIXES.
Reviewer: muse (muse muse-spark-1.3-contributor, effort medium).
The only change since the prior SHIP review deletes test_medium_marker_policy_is_documented_with_pr_routing instead of updating it. Only one of its five assertions went stale when tests/README.md reworded 'only when the heavy tier is needed' to 'only for code-routed pull requests...'; the other README pins and the Makefile test-medium pin still hold at head. Deleting the whole ratchet removes enforcement that medium-test heavy-tier routing stays documented, leaving future drift of the heavy-needed gate for medium-collect/medium-test unverified.
Defects without a review thread
- Medium
tests/unit/test_standardized_test_commands.py:402-411: D1: Deleted medium-tier doc-routing ratchet removes gate instead of updating stale phrase
The diff deletes test_medium_marker_policy_is_documented_with_pr_routing, which pinned that tests/README.md documents the medium-test heavy-tier routing and that the Makefile provides test-medium. At head, tests/README.md lines 195-201 still document the medium-test job, ordinary-PR skipping, and product-critical selection note, and the neighboring test at line 402 still asserts the test-medium target, so only the 'only when the heavy tier is needed' phrase went stale after the README rewording to 'only for code-routed pull requests that touch soundness paths or packaging'. Deleting the whole test instead of updating that phrase removes the only check tying README routing docs to the heavy-needed-gated medium-collect/medium-test jobs in .github/workflows/ci.yml, weakening the merge gate. Restore the test with the updated README wording.
Defects outside the diff count like the others: fix them before merge.
Scope: files changed since head 0034da936f8b390596f3927af1c060f13e646051 was reviewed.
…ation Per oracle review: only one assertion of the medium-tier doc-routing test went stale, so the test is restored and the README reworded to keep the pinned heavy-tier phrase without merge_group. Removes the now-unused pre-registered fixture digest.
There was a problem hiding this comment.
oracle-verdict: success for 3a121fafe6c84b4c412936f6d25194d6c55cf552
This result supersedes those for earlier heads; their open review threads still apply.
Tier: medium-high (touches 3 areas).
Decision: SHIP.
Reviewer: muse (muse muse-spark-1.3-contributor, effort medium).
SHIP: removal of the merge_group forced-heavy branch is safe dead-code cleanup. .github/workflows/ci.yml:7-10 triggers only on pull_request, so the branch was unreachable there, and merge-queue-retirement-2026-10-03.md:116-118 retires queue-only heavy-tier runs. README update matches the new PR-only routing; unit tests retain soundness/packaging/fail-closed coverage; comment-policy removal deletes only a stale pre-registered duplicate while two fixtures still cover the live make subprocess test.
Verified fixed: D1. Resolve their review threads.
This branch was successfully deployed
1 participant
Summary
merge_groupbranch and event argument from heavy-tier selection.Validation
make pr-preflightmake comment-policy-checkheavy-needed=false.