Skip to content

fix(connections): require verified authorization and explain retryable checks - #147

Merged
kjgbot merged 4 commits into
mainfrom
codex/web-authorization-health-20261115
Nov 16, 2026
Merged

kjgbot merged 4 commits into
mainfrom
codex/web-authorization-health-20261115

Conversation

@khaliqgant

@khaliqgant khaliqgant commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

Saved native connections previously displayed Connected whenever the credential row was ready. The Connections page now requires verified authorization for green readiness, shows the check's explanation and time, and retries through Refresh. Known sync failures remain warnings even when authorization verifies. Rejected credentials say Authorization inactive without claiming expiry or deletion.

Consumes additive relay-control health fields, including GitHub App authentication. Older servers show unverified when proof is absent. Existing logos and controls remain. Explicit Refresh passes refreshAuthorization=true to bypass the control-plane proof cache; ordinary loads reuse short-lived revision-bound proof.

Validation after rebasing on main: npm run lint; npm test -- --maxWorkers=1 --no-file-parallelism (982 tests/62 files); npm run build. Regressions cover unknown → Refresh → verified, forced provider retry, authorization with sync failure, and present saved credentials rejected by the provider.

Depends on AgentWorkforce/relay-control#186 and merged AgentWorkforce/relayfile-providers#24; hosted parity is AgentWorkforce/cloud#6324. Khaliq authorized merging once green on 2026-11-16. Current-head CI and review checks are green; control dependency #186 merged as 59370e216ee72275ad1be6683c6010f9c592ef1c. The merge hold is released. No manual deployment.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T07:38:25.962835Z d7982cb PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The connection contract and flow connection view now support authorization metadata and github_app authentication. The view displays authorization status, check explanations, and check times. Connection status labels account for authorization state, and tests cover unknown and active authorization results.

Changes: Authorization status display

Layer / File(s) Summary
Carry authorization metadata
src/admin/contracts.ts, src/flows/flow-connections.tsx
The connection contract and flow entry type include authorization fields and github_app authentication. The entry mapping copies authorization fields and upstreamConnected from provider connections.
Present authorization status
src/flows/flow-connections.tsx, src/flows/flow-connections.test.tsx
The view labels github_app as “App credentials,” explains authorization check results, and shows authorization status and check time. Connection status labels account for authorization state. Tests cover unknown and active authorization, including a sync error.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix

Merge Risk: Minimal · up to d7982

The Connections page now separates verified authorization from local credential and sync status, and shows "Authorization unverified" when proof is missing. The changes are additive and optional, so older servers degrade safely. The retry behavior depends on the coordinated relay-control change that the PR says must be reviewed and deployed with it.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: the Connections page now requires verified authorization before showing a connection as ready, and it explains retryable authorization checks. The changeset adds autho…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description states that saved native connections previously showed Connected whenever the credential row was ready, and that the Connections page now requires verified authorization for green read…
Full details: Title check

Explanation

The title names the main change: the Connections page now requires verified authorization before showing a connection as ready, and it explains retryable authorization checks. The changeset adds authorization status, reason, and check time to the provider connection schema and the FlowConnections UI, and adds tests for unknown-to-verified refresh and sync errors that persist under active authorization. The title is specific, short, and free of vague terms.

Full details: Description check

Explanation

The description states that saved native connections previously showed Connected whenever the credential row was ready, and that the Connections page now requires verified authorization for green readiness, shows the check explanation and time, and retries through Refresh. This matches the changeset (authorization status fields, Ready/unverified labels, Refresh bypass of the proof cache, and the new regression tests). It also gives validation details and dependencies. The description is on-topic and specific, so the check passes.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

A rabbit checks the status light,
Unknown means try again, all right.
Active brings a “Ready” sign,
App credentials join the line.
I nibble clover, checks complete!

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b80e36c7-ec34-4696-a4a9-9a185bfdf438
Commits

Reviewing files that changed from the base of the PR and between 577bf62 and d7982cb.

Files selected for processing: 3

  • src/admin/contracts.ts
  • src/flows/flow-connections.test.tsx
  • src/flows/flow-connections.tsx

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@greptile-apps

greptile-apps Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] No new actionable issues were found; the stated coordinated merge and deploy hold still applies.

Summary

The Connections page now requires verified authorization before showing Ready.

  • Saved connections show Ready only after authorization is verified.

The earlier wording finding is fixed: inactive authorization no longer claims that credentials expired. The coordinated merge and deploy hold remains in place.

Reviews (4) · Last reviewed commit: "fix(connections): bypass cached proof on..." · Reviewed by Greptile

Comment thread src/flows/flow-connections.tsx Resolved
@kjgbot
kjgbot force-pushed the codex/web-authorization-health-20261115 branch from 7ce8284 to 82a0c8c Compare November 16, 2026 19:39
@kjgbot
kjgbot merged commit 5026064 into main Nov 16, 2026
7 checks passed
@kjgbot
kjgbot deleted the codex/web-authorization-health-20261115 branch November 16, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants