Repository navigation
fix(connections): verify native credentials with shared provider checks - #186
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Devin Review found 3 potential issues.
1 flag not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b83d834baa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Review at 9f73543 (comment only; the PR body holds it, so no approval yet).
-
Not installable yet.
@relayfile/connection-health@0.1.0is not on the registry, sonpm cifails and "Typecheck and test" is red. The lockfile pins a sha512 integrity for the locally packed tarball; after publication the registry tarball must be byte-identical ornpm cistill fails. Safer: publish, then re-runnpm install @relayfile/connection-health@0.1.0and commit the refreshed lock entry. -
A member GET now writes and calls out. On main
runtimeTokenis reached only through the internal service route. WithlistHealth, everyGET /integrationsandGET /integrations/providersby any workspace member runsruntimeToken(OAuth refresh, credential rewrite,markErrorflippingstatustoerror) plus a provider request per connection. Worth stating in the PR body, and worth confirming the queue's semantics since I cannot read the package: cache TTL per key, concurrency bound, and a request timeout onsignalso a hanging provider cannot stall the listing. The key includesrecord.version, whichmarkErrorbumps, so a failing connection is re-probed on every listing. -
Catch-all in the probe. The
catchmaps every error, including database failures fromthis.get, tounknown/credentials_unavailable. Consider rethrowing non-ConnectionError/non-provider errors so an outage is not reported as a credential state. -
Minor:
listHealthcallsthis.getup to three times per connection; a single read after the probe would do.
Local checks here could not run (dependency missing); the review is static.
|
The repository guidance audit landed on |
98683e5 to
49361c7
Compare
49361c7 to
58459f1
Compare
|
Follow-up to the visible review on
The runtime listing retains its boolean local-readiness contract; management listings distinguish native binding presence from provider authorization, and the matching web UI renders rejected authorization as inactive. The guidance/README split was reconciled on main. Local final validation: typecheck, 13 HTTP/DB admin tests, build. The updated repeated-list regression proves cache reuse, forced Refresh retries, refusal vs outage and secret exclusion. Khaliq has directly authorized merging once current-head CI/reviews are green; no manual deployment is requested. |
Native management listings previously treated saved credentials as authorization proof. The listing and provider catalog now verify credentials through their canonical authority and expose status/reason/check time separately from local readiness. Runtime/environment listings retain their existing readiness contract.
Consumes published
@relayfile/connection-health@0.1.1(AgentWorkforce/relayfile-providers#24, now merged). Tokens carry the exact credential revision captured with them, including after refresh; same-ID reconnects cannot inherit previous proof. Expired, unrefreshable tokens retain inactive status across the store's error marker. A present native binding remains distinct from provider acceptance, and relay-web#147 prioritizes rejected authorization.Completed proofs cache for 30 seconds under the workspace/credential revision. Explicit Refresh (
refreshAuthorization=true) bypasses that cache. Unknown results never cache. The eight-slot queue permits at most five seconds waiting plus five seconds active and 64 pending entries. Unknowns emit sanitized, rate-limited provider/reason diagnostics. As before for runtime use, checking expired OAuth credentials can refresh canonical tokens or record an expiry marker; this is done inside the credential authority, never in relayfile-control.Validation after rebasing on main:
npm run typecheck;node --import tsx --test --test-concurrency=1 test/admin.test.ts(13 tests);npm run build. Coverage includes HTTP/DB checks, repeated-read cache reuse, explicit Refresh, refusal vs outage, secret exclusion, unchanged internal readiness, repeated expiry, and reconnect races. One race regression fails when atomic token-version binding is reverted. The registry tarball matches the reviewed artifact and includes its compiled exports.Khaliq authorized merging once green on 2026-11-16. Current-head full CI and PostgreSQL verifier are green: https://github.com/AgentWorkforce/relay-control/actions/runs/43941638945 . All visible feedback is addressed; the merge hold is released. No manual deployment or credential-authority duplication in relayfile-control.