Repository navigation
Share every query and form value by default, and no cookie but 51D_ ones when all Evidence is shared - #155
Merged
Conversation
…nes when all Evidence is shared Follows the rule James Rosewell decided on 14 November 2026. The pull request body quotes it and says what each language changes.
jwrosewell
marked this pull request as ready for review
November 14, 2026 23:30
This was referenced Nov 14, 2026
jwrosewell
added a commit
to 51Degrees/documentation
that referenced
this pull request
Nov 15, 2026
…o package names every package's version yet (#323) [#321](#321), merged into `rc` on 15 November, describes the usage sharing rules of the specification after [specifications#155](51Degrees/specifications#155) and [#156](51Degrees/specifications#156) as if every language followed them. At 02:06 UTC on 15 November that was true of two languages for one change, from a search of each language repository's pull requests.
jwrosewell
added a commit
to 51Degrees/51degrees-dotnet
that referenced
this pull request
Nov 15, 2026
… ones (#244) [specifications#155](51Degrees/specifications#155) changed two usage sharing defaults. Every query string and HTTP form parameter is now shared by default, and a cookie whose name does not start `51D_` is never shared, even when all Evidence is. .NET shared only the parameters starting `51D_` and the ones a caller named, unless the caller turned on share all query string parameters, and it shared every cookie when all Evidence was shared.
This was referenced Nov 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Usage Sharing Element differs from the rule the cloud service follows in two places.
51D_are shared (lines 70 to 72), and share all query string parameters defaults to false (line 402).51D_applies only "Unless all Evidence is shared" (lines 65 to 68), so turning on share all Evidence shares every cookie a site sets, its session cookie included (lines 89 and 90 and 309 to 311).James Rosewell decided the rule for every package on 14 November 2026, in these words.
What changed
All in
pipeline-specification/pipeline-elements/usage-sharing-element.md.cookie.key whose field does not start51D_, whatever the configuration and even when all Evidence is shared. Thecookie.line leaves the list that applies only when all Evidence is not shared.query.line in that list now applies only when share all query string parameters is off, and a new sentence says that option is on by default, so every query string and HTTP form parameter is shared unless a user turns it off.51D_, as no other cookie is. It used to be shared whenever all Evidence was.51D_.The raw Cookie header (
header.cookie) was already never shared and stays so. No option is removed or renamed, so a user who wants only the51D_query values and their own list turns share all query string parameters off.What each language changes
Every language's Usage Sharing Element changes in its own draft, with tests, linking this one.
51D_is still not shared, the session cookie included.Merging with #146
#146 also changes the session tracking paragraph, at other lines. A trial merge of #146's head 79c84b0 into this branch merged with no conflict, so the two can merge in either order.
What remains
The documentation's usage sharing page describes these defaults. It follows in documentation#316 once this merges.
Build
The specifications have no build. The checks on the head, b6fae7f, are green, being utm-link-lint and Only rc into main.