Repository navigation
Name the languages still on the old usage sharing defaults, and say no package names every package's version yet - #323
Merged
Conversation
…o package names every package's version yet Go and Rust have the new defaults. .NET, Java, Node.js and Python still share only 51D_ query values and the allow list by default, and share every cookie when all evidence is shared. The package versions are not in any package yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#321, merged into
rcon 15 November, describes the usage sharing rules of the specification after specifications#155 and #156 as if every language followed them. At 02:06 UTC on 15 November that was true of two languages for one change, from a search of each language repository's pull requests.51D_ones even with all Evidence shared. Go (51degrees-go#154) and Rust (51degrees-rust#458) have it onrcfor their Monday releases. Node.js (51degrees-node#135) and .NET (51degrees-dotnet#244) have it in open drafts. Java and Python have no pull request for it.What the four languages do today
Each at its
rcon 15 November.51D_ones and the included list, empty by default (ShareUsageBuilderBase.csline 128), every one only afterSetShareAllQueryStringParameters(true)(line 295)EvidenceKeyFilterShareUsage.csline 276)51D_ones and the included list, empty by default (ShareUsageBuilderBase.javaline 59,EvidenceKeyFilterShareUsage.javaline 230)EvidenceKeyFilterShareUsage.javaline 200)51D_ones andqueryWhitelist, "By default query string and HTTP form parameters are not shared unless prefixed with '51D_'" (shareUsage.jslines 106 to 110 and 174 to 178)shareAll, line 154)51D_ones andquery_whitelist, empty by default (share_usage.pyline 106)share_all, line 111)In all four the raw
Cookieheader is never shared, as #321 already says.What changed
src/pipelineapi/features/usagesharing.md. After the rules, a paragraph says Go and Rust follow them, and that in .NET, Java, Node.js and Python sharing all query string parameters is still off by default and sharing all Evidence shares every cookie, never theCookieheader. "What else each record carries" no longer lists every package's version as something the record holds. It names the version of the Pipeline, which is what theVersionelement carries today, and says naming every package in use is not in any package yet.src/pipelineapi/concepts/data/evidencekeyfilter.md. The same exception for the four languages, after the paragraph on what is never shared.When this merges
Before the documentation's
rcreachesmain, once the Monday language releases are known, so that #321 and this draft reachmaintogether. The language list is finished then. If Node.js #135 or .NET #244 is in its language's Monday release, that language moves to the Go and Rust sentence. If a language ships the package versions, the record sentence changes too.What remains
Finishing the language list once the Monday releases are known.
Build
Checks on the head, 14f1755, all green.
usagesharing.mdorevidencekeyfilter.md. The one warning on a page undersrc/pipelineapiis the existing one onexamples/customelement/cloud.mdline 130..utm-lint.json({ "mode": "forbid" }) requires.