Repository navigation
Say what usage sharing shares and how to hand it the web request - #316
Merged
Merged
Conversation
The rules follow the usage sharing element specification. The element accepts no Evidence and reads the web request each web integration adds as server.http-request, never shares the Cookie header, compares keys without regard to letter case and always shares the Resource Key and License Key. A new section says how an application that builds its own Evidence hands over the request in each language.
Contributor
jwrosewell
marked this pull request as ready for review
November 15, 2026 00:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The usage sharing page gives four rules for what is shared, and they no longer match what the packages do or what the specification says.
server.http-request, which is how a header no other element reads is still shared. An application that builds its own Evidence through the Pipeline's filter has to hand that request over, and the page does not say so.Cookieheader is never shared. The releases on Monday 16 November make every language agree on that. 51degrees-dotnet#172 blocks onlyCookieby default, where .NET also blocked a header namedCookies, and 51degrees-rust#407 stops Rust sharing the Cookie header when all Evidence is shared.What the specification says
Usage sharing element, Accepted Evidence and Shared Evidence, lines 6 to 90 at c8128ca4. Lines 8 and 18 to 29:
Lines 41 to 74 give the keys that are never shared (
id.email,id.salt,request-query,request-pathandheader.cookie) and the rules for the rest, line 35 says "Keys are compared without regard to case", and lines 76 to 79 say the Resource Key and License Key are always shared. The options table, line 404, gives the default for blocked headers as "All HTTP headers are shared exceptCookie".What changed
src/pipelineapi/features/usagesharing.mdonly.rc.IWebRequestEvidenceService.csline 44,WebPipeline.csline 322Constants.csline 164,EVIDENCE_HTTPREQUEST_KEYWebRequestEvidence.javaline 67ShareUsageEvidence.javaline 44,HTTP_REQUEST_KEYevidence.jsline 371, inaddFromRequestevidence.addkeeps a value usage sharing would shareweb.pyline 74,webevidencemiddleware.goline 218evidence.golines 108 to 130,EvidenceHTTPRequest,NewWebRequestandWithClientIPrequest.rsline 244,build_evidenceevidence.rsline 362,EvidenceBuilder::http_requestThe rest of the page, including the snippets that add
server.client-ip,header.hostandheader.usage-from, is unchanged and still right.When this merges
After the Monday 16 November releases reach
main, because theCookierule in .NET and Rust is on theirrcuntil then.What remains
query.session-idandquery.sequencenever take part in the repeat check and are always written to the record. The page's "Repeated evidence" section says nothing at that level of detail today, so it needs no change, and a sentence can follow once that draft merges.Build
Checks on the head, 8c1572d, all green.
src/pipelineapi/features/usagesharing.md..utm-lint.json({ "mode": "forbid" }) requires.