Repository navigation
End every Pipeline developer and Location console example with a Find out more section - #134
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
No Pipeline developer example and no Location example ended with a "Find out more" section, found in the audit of the examples on 13 November. The 51Degrees rule for examples is that every example ends with a clearly separated "Find out more" section that gives the person running it links to follow up, being the relevant repositories as plain addresses and 51degrees.com pages tagged with the campaign convention that common-ci's
scripts/utm-lint.ps1checks.#133 does this for the Device Detection and IP Intelligence examples. This draft does the rest of the console examples, the five Pipeline developer examples that have a
mainmethod and the two Location shell examples.What changed and why
Line numbers are at this head, cfd047a.
Mainof the flow element, on-premise engine, cloud engine, usage sharing and 51Did examples gainswriteFindOutMore, whichmaincalls after the example has run, so therunmethod that the documentation shows is unchanged. The section lists the example's own documentation page and the documentation page of the feature it shows, each tagged withutm_source=code,utm_medium=example,utm_campaign=51degrees-java, the example asutm_contentandfind-out-moreasutm_term, then this repository and the specifications repository. The 51Did example lists the Identifiers page and the contact page, as "Ask about 51Did", in place of a feature page. For example, the flow element example's is inMain.javalines 73 to 98.FindOutMoreingeo-location.shell.exampleswrites the section, with the example's documentation page, the Location page and this repository.cloud/GettingStarted.javalines 121 to 124 andCombiningServices.javalines 182 to 185 call it as the last line ofmain, so the section also ends the output when no resource key is set and the example only says how to get one.What it releases
The five developer examples and
geo-location.examplesare published packages. Under the version per package change (#63) a change to any of them alone releases nothing, because itsci/packages.jsongives each example package anIgnoreglob over its whole folder,pipeline/pipeline.developer-examples/**for the developer examples andlocation/geo-location.shell.examples/**for the Location ones, as itsci/packages.ps1says ("give an Ignore glob over their whole folder, so a change to one releases nothing"). All six are in Monday's plan anyway, as dependants of changed packages (Publish dry run 43559110241 on #63), so this draft adds no package to the release.Tests
Tests first, each commit pair a test then its change.
FindOutMoreTestsin each of the five developer example modules runsMain.main, and checks that the section follows the example's own output, has a closing rule, lists exactly two 51degrees.com pages, each carrying the five campaign tags in order, and lists this repository.FindOutMoreTestsingeo-location.shell.examplesrunsGettingStartedandCombiningServiceswith no resource key and makes the same checks.Each red and green ran on
ubuntu-lateston a throwaway branch holding the commit and a temporary workflow that ranmvn -Pdev -pl <the modules> -am testwith only the named tests.tmp/java-fomp-red). The fiveFindOutMoreTestsfailed and the fiveExampleTestsclasses passed, 14 tests.tmp/java-fomp-green). All 19 passed, the fiveFindOutMoreTestsand the 14 tests of the fiveExampleTestsclasses.tmp/java-fomloc-red). Both tests failed.tmp/java-fomloc-green). Both passed.Full build
Run 43563430562 built cfd047a merged with
rc(6e03a25) on nine configurations, Ubuntu x64 with Java 8, 11, 17 and 21, Ubuntu arm64 with Java 17, and Windows with Java 8, 11, 17 and 21, and every job passed. The six new test classes passed in all nine jobs. Each of its tenSetting 'PullRequestSha'lines names cfd047a, and its Configure job printed "Left out 6 macOS entries".macOS was left out of this draft's full build under the 9 November decision. The rc head is built with macOS before it merges into main.
Base branch
rc. The branch starts fromrcat 6e03a25. A trial merge withrcat ceab088, which has since taken #27, #124 and #43, was clean on 14 November at 09:30 UTC. #115 changes the configuration page address on two lines of each Location example, away from the lines this draft adds.What remains