Skip to content

Test the Location web examples and the client-side element web example, and let the Location examples take a resource key from the environment #151

Open

Description

@jwrosewell

The console examples now end with a Find out more section and tests run them with no settings (#133, #134). Three examples have no test that runs them at all, so nothing checks their pages or that they end with the section. They are the Location MVC and servlet web examples (location/geo-location.web.examples/geo-location.web.examples.mvc and .servlet) and the client-side element web example (pipeline/pipeline.developer-examples/pipeline.developer-examples.clientside-element-mvc).

The Location web examples' options files carry <ResourceKey>!!YOUR_RESOURCE_KEY!!</ResourceKey> (51Degrees-Cloud.xml line 34 in both), and the Location shell examples take a key only by editing the source (cloud/GettingStarted.java line 88, CombiningServices.java line 134), where the Device Detection and IP Intelligence examples read _51DEGREES_RESOURCE_KEY or TestResourceKey.

What a cloud example does when no resource key is set waits on the rule for cloud examples that is still open. Once the rule is settled, read the key as the other examples do, follow the rule, end each page with the section, and add tests that start each example with no settings, red first. The client-side element example uses no 51Degrees data and needs no key, so its test and section need not wait.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions