Repository navigation
zulip: Allow cert_bundle to be a directory. - #952
Open
Johnboard-cmyk wants to merge 1 commit into
Open
Johnboard-cmyk wants to merge 1 commit into
Johnboard-cmyk wants to merge 1 commit into
Conversation
The requests library accepts a directory of CA certificates (such as /etc/ssl/certs) as the verify parameter, but Client rejected any cert_bundle that was not a file. Accept directories as well, and add tests covering a file bundle, a directory bundle, and a missing path. Fixes zulip#748.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The requests library accepts a directory of CA certificates (such as /etc/ssl/certs) as its verify parameter, but Client rejected any cert_bundle that was not a file. Accept directories as well.
Fixes #748. This supersedes #749, which has been inactive since March 2022. (This also replaces #951, closed and reopened so the commit message itself carries the Fixes reference.)
Fixes: #748
How did you test this PR?
Tests: new TestCertBundle tests in zulip/tests/test_client.py cover a file bundle, a directory bundle, and a missing path; the full zulip/tests/ suite passes, and ruff and mypy are clean.
Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: