Add indentation rule for array creation expressions - #139
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @carestad on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
MrSubidubi
left a comment
There was a problem hiding this comment.
Looks good, but needs some reformatting as noted in CI. Could you look into that, please?
@MrSubidubi Sure thing! Should be updated now 🙂 |
@MrSubidubi cheers, but it seems something failed again in the pipeline 😭 |
|
Yep, GitHub outage yesterday 🥲 Love cleaning up after that |
Adds indentation rules for PHP array creation expressions.
Pressing Enter after an opening
[orarray(left the new line at column 0.indents.scmonly matched nodes containing{/}, so neither array form was covered - both use brackets or parentheses.Before:
After:
Both short
[]and legacyarray()syntax are handled; in tree-sitter-php both produce an array_creation_expression` node, differing only in the closing delimiter.Note the rules are scoped to
array_creation_expressionrather than matching]or)generally, since]also closes array access ($foo['bar']).Tested locally on Zed v1.13.1 with a fresh profile.
Fixes #138