Skip to content

docs+feat: tighten the standards reference, and deliver review conventions - #19

Merged
yuema137 merged 2 commits into
mainfrom
docs/lighter-standards
Sep 10, 2026
Merged

yuema137 merged 2 commits into
mainfrom
docs/lighter-standards

Conversation

@yuema137

Copy link
Copy Markdown
Owner

Two small changes, kept small on purpose.

1. The standards reference, 175 lines to 136

Cut explanation that repeated itself, not anything it discloses. Every limit stays: an absent tool is INCONCLUSIVE, approve does not enforce who approves, trigger: "pr" has no hook, and reading a file proves nothing about whether the agent followed it.

2. Review conventions reach the agent

The last item in the plan, in the smallest honest form. Whatever a project set to the commit trigger rides along in one report: the checks run, and the declared conventions are restated for the agent to apply to what it just committed.

This needed no new delivery path — the hook already sends a message at that moment, so the conventions are about ten lines of content added to it rather than a mechanism of their own. That is what the earlier plan would have built, had the Stop handler survived.

Conventions with the pr trigger are not orphaned: SKILL.md already routes the agent to the standards contract whenever a project declares one. The hook adds a commit-time reminder; it is not the only path, and the documentation says so.

Not done, and why

I proposed removing Step 3's approval machinery and then retracted it, so it is untouched here.

The claim behind that proposal was that it "does not enforce who approves, which its shape implies". Re-checking against the threat it exists for, that was wrong. The realistic threat is a contributor's pull request adding or changing a command that then runs when you check the branch out. The approval is bound to the command digest and lives outside the working tree, so a fresh clone has none and any change to a command revokes it — that threat is covered. What it does not cover is a local agent running approve, which is the same class as an agent running the installer, and not what the boundary was for.

It is also 72 lines out of 752, not the heaviest thing in the file. Deleting working code that blocks a real threat, on a premise I no longer believe, would have been the worse mistake.

The genuinely over-built piece was the Stop mapping, and that was already cut in #18.

Validation

Ran 165 tests ... OK (skipped=1); --check PASS on all five checks.

🤖 Generated with Claude Code

https://claude.ai/code/session_016cCs5DdUjLDkP8V3Z5x6XH

yuema137 and others added 2 commits September 9, 2026 22:12
175 lines to 136, by cutting explanation that repeated itself rather than
anything it discloses. Every limit stays: an absent tool is inconclusive, approve
does not enforce who approves, trigger pr has no hook, and reading a file proves
nothing about whether the agent followed it.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016cCs5DdUjLDkP8V3Z5x6XH
…report

The last piece of the plan, in the smallest honest form. Whatever a project set
to the commit trigger now rides along in one report: the checks run, and the
declared review conventions are restated for the agent to apply to what it just
committed.

This needed no new delivery path. The hook already sends a message at that
moment, so the conventions are ten lines of content added to it rather than a
mechanism of their own, which is what the earlier plan would have built had the
Stop handler survived.

Conventions with the pr trigger are not orphaned: SKILL.md already routes the
agent to the standards contract whenever a project declares one. The hook adds a
commit-time reminder, it is not the only path, and the documentation says so.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016cCs5DdUjLDkP8V3Z5x6XH
@yuema137
yuema137 merged commit 4d9e011 into main Sep 10, 2026
4 checks passed
@yuema137
yuema137 deleted the docs/lighter-standards branch September 10, 2026 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant