docs+feat: tighten the standards reference, and deliver review conventions - #19
Merged
Merged
Conversation
175 lines to 136, by cutting explanation that repeated itself rather than anything it discloses. Every limit stays: an absent tool is inconclusive, approve does not enforce who approves, trigger pr has no hook, and reading a file proves nothing about whether the agent followed it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016cCs5DdUjLDkP8V3Z5x6XH
…report The last piece of the plan, in the smallest honest form. Whatever a project set to the commit trigger now rides along in one report: the checks run, and the declared review conventions are restated for the agent to apply to what it just committed. This needed no new delivery path. The hook already sends a message at that moment, so the conventions are ten lines of content added to it rather than a mechanism of their own, which is what the earlier plan would have built had the Stop handler survived. Conventions with the pr trigger are not orphaned: SKILL.md already routes the agent to the standards contract whenever a project declares one. The hook adds a commit-time reminder, it is not the only path, and the documentation says so. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016cCs5DdUjLDkP8V3Z5x6XH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small changes, kept small on purpose.
1. The standards reference, 175 lines to 136
Cut explanation that repeated itself, not anything it discloses. Every limit stays: an absent tool is
INCONCLUSIVE,approvedoes not enforce who approves,trigger: "pr"has no hook, and reading a file proves nothing about whether the agent followed it.2. Review conventions reach the agent
The last item in the plan, in the smallest honest form. Whatever a project set to the
committrigger rides along in one report: the checks run, and the declared conventions are restated for the agent to apply to what it just committed.This needed no new delivery path — the hook already sends a message at that moment, so the conventions are about ten lines of content added to it rather than a mechanism of their own. That is what the earlier plan would have built, had the
Stophandler survived.Conventions with the
prtrigger are not orphaned:SKILL.mdalready routes the agent to the standards contract whenever a project declares one. The hook adds a commit-time reminder; it is not the only path, and the documentation says so.Not done, and why
I proposed removing Step 3's approval machinery and then retracted it, so it is untouched here.
The claim behind that proposal was that it "does not enforce who approves, which its shape implies". Re-checking against the threat it exists for, that was wrong. The realistic threat is a contributor's pull request adding or changing a command that then runs when you check the branch out. The approval is bound to the command digest and lives outside the working tree, so a fresh clone has none and any change to a command revokes it — that threat is covered. What it does not cover is a local agent running
approve, which is the same class as an agent running the installer, and not what the boundary was for.It is also 72 lines out of 752, not the heaviest thing in the file. Deleting working code that blocks a real threat, on a premise I no longer believe, would have been the worse mistake.
The genuinely over-built piece was the
Stopmapping, and that was already cut in #18.Validation
Ran 165 tests ... OK (skipped=1);--checkPASS on all five checks.🤖 Generated with Claude Code
https://claude.ai/code/session_016cCs5DdUjLDkP8V3Z5x6XH