Skip to content

streamline test coverage #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yslib merged 2 commits into from
Aug 7, 2026
Merged

streamline test coverage #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db82b59
streamline test coverage
yslib Aug 7, 2026
6b86e34
make config path tests portable
yslib Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 2 additions & 20 deletions dot-cli/src/config/https.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@ impl HttpsError {

#[cfg(test)]
mod tests {
use std::error::Error;
use std::io::{self, Cursor, Read};

use super::*;
Expand All @@ -123,7 +122,6 @@ mod tests {
"http://example.com/dot.toml".to_owned(),
));
assert!(matches!(require_https, HttpsError::RequireHttpsOnly { .. }));
assert!(Error::source(&require_https).is_some_and(|source| source.is::<ureq::Error>()));

let redirects = HttpsError::from_call(ureq::Error::TooManyRedirects);
assert!(matches!(redirects, HttpsError::TooManyRedirects { .. }));
Expand All @@ -139,20 +137,6 @@ mod tests {

let transport = HttpsError::from_call(ureq::Error::ConnectionFailed);
assert!(matches!(transport, HttpsError::Transport { .. }));
assert!(Error::source(&transport).is_some_and(|source| source.is::<ureq::Error>()));
}

#[test]
fn maps_ureq_io_to_the_underlying_typed_transport_source() {
let error = HttpsError::from_call(ureq::Error::Io(io::Error::new(
io::ErrorKind::ConnectionAborted,
"network stopped",
)));

let source = Error::source(&error)
.and_then(|source| source.downcast_ref::<io::Error>())
.expect("transport I/O should be the immediate typed source");
assert_eq!(source.kind(), io::ErrorKind::ConnectionAborted);
}

#[test]
Expand Down Expand Up @@ -183,12 +167,10 @@ mod tests {

let read = read_body(FailingReader).expect_err("body I/O should fail");
assert!(matches!(read, HttpsError::BodyRead { .. }));
assert!(Error::source(&read).is_some_and(|source| source.is::<io::Error>()));
assert!(read.to_string().contains("response body stopped"));

let utf8 = read_body(Cursor::new([0xff])).expect_err("invalid UTF-8 should fail");
assert!(matches!(utf8, HttpsError::InvalidUtf8 { .. }));
assert!(
Error::source(&utf8).is_some_and(|source| source.is::<std::string::FromUtf8Error>())
);
assert!(utf8.to_string().contains("UTF-8"));
}
}
Loading