fix(yew-link): surface initial internal fetch errors instead of retrying indefinitely - #4219
Open
cuishuang wants to merge 2 commits into
Open
fix(yew-link): surface initial internal fetch errors instead of retrying indefinitely#4219cuishuang wants to merge 2 commits into
cuishuang wants to merge 2 commits into
Conversation
…ing indefinitely Signed-off-by: cuishuang <imcusg@gmail.com>
|
Visit the preview URL for this PR (updated for commit d19c797): https://yew-rs-api--pr4219-master-68tx4rnl.web.app (expires Mon, 14 Sep 2026 14:34:33 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Size ComparisonDetails
✅ None of the examples has changed their size significantly. |
WorldSEnder
reviewed
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the client-side
use_linked_stateretry loop caused by initialLinkError::Internalresults not being cached.Initial fetches now cache all completed results, including infrastructure errors. This allows the suspension to resolve and exposes the error through
LinkedStateHandle::as_result()instead of creating another identical request.Refresh behavior remains unchanged:
LinkError::Internalresults from background refreshes are not cached, so an existing stale value is preserved.Fixes #4218
Checklist