Repository navigation
Share one SslContext between the channels of a factory - #776
Merged
Merged
Conversation
NettyChannelFactory and ShadedNettyChannelFactory built a new SslContext for every TLS channel: the custom certificate was parsed again, or the trust managers were wrapped again, and a new (often native OpenSSL) context was allocated for each node channel, for every auth channel and for the discovery channel created every minute. SslContext is immutable and thread-safe, so create it lazily once per factory and reuse it. A failure to create it isn't cached and is still reported on every channel creation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #776 +/- ##
============================================
+ Coverage 75.47% 75.61% +0.14%
- Complexity 3755 3763 +8
============================================
Files 396 396
Lines 16842 16845 +3
Branches 1780 1780
============================================
+ Hits 12711 12737 +26
+ Misses 3515 3492 -23
Partials 616 616 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
KirillKurdyukov
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated #763
NettyChannelFactory and ShadedNettyChannelFactory built a new SslContext for every TLS channel: the custom certificate was parsed again, or the trust managers were wrapped again, and a new (often native OpenSSL) context was allocated for each node channel, for every auth channel and for the discovery channel created every minute.
SslContext is immutable and thread-safe, so create it once per factory.