Notification delegates for individual Panels and Tabs #17

Activity

1. yasirkula

   added

   enhancementNew feature or requestNew feature or request

   on Jan 21, 2022
2. yasirkula commented on Jan 21, 2022

   

   yasirkula

   on Jan 21, 2022

   Owner

   More actions

   Thank you for the feature request! I probably won't be able to add this feature in the near future, though.
3. FSanta commented on Jan 22, 2022

   

   FSanta

   on Jan 22, 2022

   Author

   More actions

   Thanks for the response!

   Here is my current workaround - I had to make changes to the source of the plugin which could break the existing functionality:

   PanelTab - Add a new Method:

   public void AddCloseButtonListener( UnityAction call )
   {
   	closeButton.onClick.AddListener( call );
   	Internal.ChangeCloseButtonVisibility( true );
   }
   

   PanelNotificationCenter#TabIDChanged
   Disable the call to ChangeCloseButtonVisibility so it won't hide the close button again

   An example listener that simply destroys the tab if the Button is Clicked:

   panelTab.AddCloseButtonListener( () =>
   {
   	panelTab.Destroy();
   });
   

   For Panels the changes should be very similar

   Obviously, this solution is quite flawed but it is a simple workaround that will do the trick for me :)

   👍React with 👍1Reacted by yasirkula

   🚀React with 🚀1Reacted by yasirkula
4. yasirkula commented on Jan 22, 2022

   

   yasirkula

   on Jan 22, 2022

   Owner

   More actions

   Looks neat! What are its known flaws?
5. FSanta commented on Jan 22, 2022

   

   FSanta

   on Jan 22, 2022

   Author

   More actions

   I think it is quite "hacky" because it does not use the PanelNotificationCenter which was originally intended for this purpose.
   An the behavior becomes unpredictable if used together with the PanelNotificationCenter.OnTabClosed.
   For example if you happen to use both at some point:

   PanelNotificationCenter.OnTabClosed += ( PanelTab tab ) => {
   	tab.Destroy();
   };
   

   panelTab = PanelUtils.CreatePanelFor( scriptEditor, canvas ).GetTab( scriptEditor );
   panelTab.AddCloseButtonListener( () =>
   {
   	scriptEditor.GetComponentInChildren<TMP_InputField>().SetTextWithoutNotify( "You can't close yet!" );
   } );
   

   The tab will always be closed and the text won't ever show. But the same unpredictability can happen if you register multiple Delegates so maybe this is simply the responsibility of the developer.

   👍React with 👍1Reacted by yasirkula