fix(fabricator): harden framing, prevent stdio deadlocks, and add regression tests - #294
Open
chrhoffmann wants to merge 1 commit into
Open
fix(fabricator): harden framing, prevent stdio deadlocks, and add regression tests#294chrhoffmann wants to merge 1 commit into
chrhoffmann wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes non-deterministic hangs in bytecode fabrication by hardening parent/child framing in the fabricator path and adding focused regression tests.
Problem
pkgcould hang during builds due to corrupted frame headers and stream-boundary truncation in fabricator IPC, with additional risk from debug stderr handling under backpressure.Root Cause
stdin.write()calls.Changes
fabricator.tsstderrpiped and routed debug output via logger.buildFabricatorRequestChunks(...)to construct isolated frame chunks with distinct headers.fabricatorScriptfor direct regression testing.fabricator.test.tsAdded targeted unit regressions:
Validation
npm run test:unit✅npm run lint✅npm run build✅Risk / Compatibility
Reviewer Checklist
fabricator.tsfabricator.test.tscover the reported failure modesmaintarget (yao-pkg/pkg)