Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--allow-failpermits a Poisson benchmark tolerance failure; emit a stderr warning locally.No numerical tolerances, benchmark algorithms, or workflow gating policies change. Both quick backends currently report tolerance failure under the existing acceptance criterion, which requires every sampled order to meet tolerance.
Validation
make devpassed on Python 3.12: formatting, Ruff, mypy (74 source files), architecture, documentation, full 385-test collection (one optional skip), and all 16 cut-panel evaluations.GITHUB_ACTIONS=true.34bed3954eae3d626c3af72e3db0a43f014c68f7: all five jobs succeeded. Poisson smoke jobs remain intentionally non-gating for numerical acceptance.The separate Weekly Janitor PR-creation permission failure is not addressed by this change.