Repository navigation
Fix Python producer inherited Avro content types - #671
Merged
Merged
Conversation
Preserve JSON and binary Avro variants over the same schema, normalize the reported Avro alias only for serialization, and retain datacontenttype in structured Kafka envelopes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: dfdd160a-bd4a-4a7e-bfb0-34d189fc944a Signed-off-by: Clemens Vasters <clemens@vasters.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #670.
Verification
Seven focused regression/compatibility cases pass locally. The new generated Kafka test executes actual send methods with a recording producer, decodes wire payloads using the independent Avro reader, and checks JSON payloads, structured envelopes, defaults, explicit overrides, canonical aliases and MIME parameters. AMQP generated defaults and generated Python compilation are covered. No live-broker AMQP claim is made.
The existing Kafka byte-preserving marshaller was already present on main; the new tests exercise the complete send path rather than just that helper.