Move hold_cluster_spam below act_cluster_spam_* rules to fix shadowin… - #76
Open
GraceyDugar wants to merge 1 commit into
Open
Move hold_cluster_spam below act_cluster_spam_* rules to fix shadowin…#76GraceyDugar wants to merge 1 commit into
GraceyDugar wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #67
The rules engine is first-match-wins, and hold_cluster_spam (a broad skip on startsWith("cluster_spam")) was ordered above the three act_cluster_spam_* action rules that share its prefix, making suspend/bounce/label unreachable for base cluster_spam decisions.
This moves hold_cluster_spam below the three action rules so it acts as the catch-all for decisions with no actionable label, mirroring how the cluster_spam_extended family is already ordered.
Note: the file header says it's mirrored from a GrowthBook dynamic config, so the live config may differ but this makes the published rules internally consistent either way. Happy to add a test for the ordering with some guidance on where the rule-evaluation tests live.