Skip to content

refactor(lower): give semantic lowering feature-local ownership - #205

Open
e54-bot wants to merge 1 commit into
mainfrom
codex/issue-203-lowering-ownership
Open

refactor(lower): give semantic lowering feature-local ownership#205
e54-bot wants to merge 1 commit into
mainfrom
codex/issue-203-lowering-ownership

Conversation

@e54-bot

@e54-bot e54-bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • split declaration/symbol handling, statement/control-flow lowering, expression/builtin/member resolution, and OPY special forms into explicit internal modules
  • keep shared Lowerer state and public lowering entry points unchanged
  • preserve existing semantic, diagnostic, provenance, and Workshop ownership behavior

Verification

  • cargo fmt --all -- --check
  • cargo clippy --workspace --all-targets --all-features -- -D warnings
  • cargo test --workspace --all-targets --all-features
  • python3 -m unittest discover -s tools/overpy/tests

Fixes #203

Teakowa
Teakowa previously approved these changes Sep 7, 2026

@Teakowa Teakowa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Teakowa
Teakowa dismissed their stale review September 7, 2026 02:37

Withdrawing approval because the required independent ablation could not be executed in the current environment; code review found no defect, but verification is incomplete until that check is run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Give OPY semantic lowering discoverable feature-local module ownership

2 participants