Skip to content

Add mkdocs-glightbox for clicking on screenshots to enlarge them - #56

Merged
Mark90 merged 3 commits into
eenblam/19-enhancement-not-a-video-crash-coursefrom
mkdocs-glightbox
Aug 14, 2026
Merged

Add mkdocs-glightbox for clicking on screenshots to enlarge them#56
Mark90 merged 3 commits into
eenblam/19-enhancement-not-a-video-crash-coursefrom
mkdocs-glightbox

Conversation

@Mark90

@Mark90 Mark90 commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@eenblam

eenblam commented Aug 11, 2026

Copy link
Copy Markdown

This is failing for me. If I pull your branch, run uv sync, then ./setup_subprojects.sh, and then run the docs server...

╰─>$ uv run --no-sync mkdocs serve

 │  ⚠  Warning from the Material for MkDocs team
 │
 │  MkDocs 2.0, the underlying framework of Material for MkDocs,
 │  will introduce backward-incompatible changes, including:
 │
 │  × All plugins will stop working – the plugin system has been removed
 │  × All theme overrides will break – the theming system has been rewritten
 │  × No migration path exists – existing projects cannot be upgraded
 │  × Closed contribution model – community members can't report bugs
 │  × Currently unlicensed – unsuitable for production use
 │
 │  Our full analysis:
 │
 │  https://squidfunk.github.io/mkdocs-material/blog/2026/02/18/mkdocs-2.0/

INFO    -  Building documentation...
INFO    -  [macros] - No default module `main` found
INFO    -  Merging config from orchestrator-core/mkdocs.yml (prefix=orchestrator-core)
INFO    -  Merging config from orchestrator-ui-library/mkdocs/mkdocs.yml (prefix=mkdocs)
INFO    -  [macros] - Config variables: ['extra', 'config', 'environment', 'plugin', 'git', 'generator', 'social', 'macros', 'filters', 'filters_builtin']
INFO    -  [macros] - Config macros: ['context', 'macros_info', 'now', 'fix_url']
INFO    -  [macros] - Config filters: ['pretty', 'relative_url']
INFO    -  Cleaning site directory
INFO    -  Doc file 'architecture/at-a-glance.md' contains an unrecognized relative link '../../orchestrator-core/guides/tasks/', it was left as is. Did you mean '../orchestrator-core/guides/tasks.md'?
INFO    -  mkdocstrings_handlers: Formatting signatures requires either Black or Ruff to be installed.
ERROR   -  mkdocstrings: lso.tasks.PlaybookFinishedHandler could not be found
ERROR   -  Error reading page 'lightweight-service-orchestrator/playbooks/callback.md':
ERROR   -  Could not collect 'lso.tasks.PlaybookFinishedHandler'

The ruff thing is a red herring; installing ruff into the project gets rid of that INFO log but doesn't address the issue.

If I omit lso from the setup dependencies, I get a similar error for orchestrator-core. Removing orchestrator-core is a no-go, since I need to resolve a URL to the project in the article on my branch.

@Mark90

Mark90 commented Aug 12, 2026

Copy link
Copy Markdown
Contributor Author

This is failing for me. If I pull your branch, run uv sync, then ./setup_subprojects.sh, and then run the docs server...

Try a completely clean setup?

mkdir testwfo
cd testwfo
git clone git@github.com:workfloworchestrator/workfloworchestrator.github.io.git .
git checkout mkdocs-glightbox
uv sync
./setup_subprojects.sh
uv run --no-sync mkdocs serve -a localhost:8006

This works for me consistently

@Mark90

Mark90 commented Aug 14, 2026

Copy link
Copy Markdown
Contributor Author

This is failing for me. If I pull your branch, run uv sync, then ./setup_subprojects.sh, and then run the docs server...

This is fixed now, the problem only seemed to surface when changing branches.

@Mark90
Mark90 marked this pull request as ready for review August 14, 2026 14:23
@Mark90
Mark90 merged commit 30dd427 into eenblam/19-enhancement-not-a-video-crash-course Aug 14, 2026
1 check passed
@Mark90
Mark90 deleted the mkdocs-glightbox branch August 14, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants