Repository navigation
Advertise flat object schemas for browser_handoff and browser_credentials in OMP - #63
Conversation
…ials in OMP OpenAI-compatible providers reject a tool whose root parameters schema is a union, so OMP runs that send extension tools without normalization failed on every Codex and DeepSeek request. Both tools now use one strict object, as browser_open and browser_snapshot already do; Core still enforces the fields each operation requires.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![wolf-maintainer[bot]](https://avatars.githubusercontent.com/in/4804189?s=60&v=4){kind=small}
There was a problem hiding this comment.
P1 — scoped root-schema compatibility fix; Core's strict RPC schemas preserve operation-specific validation, and the regression test covers every registered OMP tool.
Should-fix: add the required ## Unreleased changelog entry for the touched OMP package.
Verification note: bun test packages/omp/test/extension.test.ts could not start because this checkout lacks the typebox dependency.
Thanks for the focused fix.
1 participant
OpenAI-compatible providers (Codex, DeepSeek) reject a tool whose root parameters schema is a union. When OMP sends extension tools without its own schema normalization (for example
omp --no-tools), every request on those providers failed withInvalid schema for function 'browser_handoff'.browser_handoffandbrowser_credentialsnow advertise one strict object, matchingbrowser_openandbrowser_snapshot. Core still enforces which fields each operation or action requires. Pi mode schemas are unchanged.Verification:
omp --no-toolswith the built adapter: Codex and DeepSeek requests that previously returned the schema error now succeed.