Skip to content

Expose Standard input actions and wait conditions in OMP tool schemas - #61

Merged
wolfiesch merged 2 commits into
mainfrom
fix/omp-standard-action-schema
Oct 4, 2026
Merged

wolfiesch merged 2 commits into
mainfrom
fix/omp-standard-action-schema

Conversation

@wolfiesch

Copy link
Copy Markdown
Owner

Summary

  • OMP registers tools with Zod schemas built in packages/omp/src/index.ts, separate from the TypeBox schemas Pi uses. Add Standard input actions and background popup tabs #60 updated only the Pi side, so OMP agents could not call hover, double_click, context_click, press modifiers, frame_id, expect_download, dialog prompt_text, or the new wait conditions.
  • Mirror the Pi and protocol schemas for browser_snapshot, browser_act, and browser_wait.
  • Add a parity test that fails when the OMP schemas omit any field or enum value the Pi schemas accept.

Verification

  • bun run typecheck, bun test, and bun run build in packages/omp; the parity test fails against the previous schemas.
  • Loaded the built adapter in a fresh OMP process and ran hover, press with modifiers, and a selector-state wait against a live task tab.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-04T20:23:38.628682Z 3119fb8 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3119fb824c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/omp/src/index.ts Outdated
Comment thread packages/omp/test/extension.test.ts Outdated

@wolf-maintainer wolf-maintainer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 — the implementation is narrowly scoped and restores the OMP fields and values added by #60.
Should-fix: the parity test compares every Pi tool against a single global OMP vocabulary, so tool-specific omissions can remain green.
Local validation could not start because this checkout lacks typebox and tsc.
Thanks for closing the OMP schema gap.

Comment thread packages/omp/test/extension.test.ts Outdated
@wolfiesch
wolfiesch merged commit 0651bec into main Oct 4, 2026
8 checks passed
@wolfiesch
wolfiesch deleted the fix/omp-standard-action-schema branch October 4, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant