Repository navigation
Expose Standard input actions and wait conditions in OMP tool schemas - #61
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3119fb824c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
P1 — the implementation is narrowly scoped and restores the OMP fields and values added by #60.
Should-fix: the parity test compares every Pi tool against a single global OMP vocabulary, so tool-specific omissions can remain green.
Local validation could not start because this checkout lacks typebox and tsc.
Thanks for closing the OMP schema gap.
Summary
packages/omp/src/index.ts, separate from the TypeBox schemas Pi uses. Add Standard input actions and background popup tabs #60 updated only the Pi side, so OMP agents could not callhover,double_click,context_click, pressmodifiers,frame_id,expect_download, dialogprompt_text, or the new wait conditions.browser_snapshot,browser_act, andbrowser_wait.Verification
bun run typecheck,bun test, andbun run buildinpackages/omp; the parity test fails against the previous schemas.hover,presswith modifiers, and a selector-state wait against a live task tab.