Repository navigation
feat: show notices as corner toasts that leave or stay by level - #2629
Merged
Merged
Conversation
This was referenced Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
When something goes wrong, Hide shows a strip across the window under the top row: a refused command, an unsaved close, a failed agent start, draft recovery.
Each strip pushes the whole screen down a line, and every one looks the same whether it only reports what happened or waits for the operator to act.
The operator asked for these to appear as toasts in the lower right corner instead: passing ones leave on their own, serious ones stay and look different.
Before → After
The After capture is the production
Toastpart in the System gallery; the second image shows an info notice's countdown bar about 3 seconds in.Decide
Not verified
s3.spec.tsdraft recovery,s7.spec.tsDon't save) were not run locally; their data attributes are unchanged, and CI runs them.Evidence
web typecheck,web lint,node scripts/check-design-contract.mjs(tokens, contrast, part counts) pass; unit testsui.test.ts,toast.test.tsx,errorNotice.test.ts,remote.test.ts,RenderBoundary.test.tsxpass (38 tests).Toastsection captured in Light and Dark with headless Chromium; long Korean text wraps at word boundaries (break-keep).Tests
ui.test.tsholds the corner's cap, replacement and dismissal throughuseUiStore;toast.test.tsxholds the info countdown, its pause and resume, and that an important notice stays.splice(0, 1), the cap test failed); a hold that restarts the whole count instead of resuming (the resume test expects it gone 1 s after leaving).ui.test.ts,toast.test.tsx,errorNotice.test.tsx 10 local runs, all green.vi.useFakeTimers.Risky files
web/src/App.tsx- every window-wide notice moved from the column under the top row into one absolutely placed corner stack; each keeps its own render boundary.web/src/ui.ts- the singlenoticeslot became a capped list; callers that cleared it now dismiss by rule (refreshable,dontSavedisplay,agent_capacitykey).Verification record
7f624a962678, heade9d7ef696e6f.bash scripts/verify-web.sh web typecheck,web lint,web test <5 files>,node scripts/check-design-contract.mjs.sonnerand its unused partcomponents/ui/sonner.tsxremoved; the gallery'sSonnersection becameToast.scripts/ui-parts-baseline.jsonlowered:DraftRecovery.tsxandWorkspaceDialogs.tsxno longer draw raw buttons.