Repository navigation
fix(ci): publish Session from its src manifest - #244
Draft
AndrewKirkovski wants to merge 1 commit into
Draft
AndrewKirkovski wants to merge 1 commit into
AndrewKirkovski wants to merge 1 commit into
Conversation
Session moves its manifest to src/ so that its embed entries resolve against the module sources. The companion publisher read module/wippy.yaml and would fail on such a release. It now uses src/wippy.yaml when one exists, and a dry-run pack below 400 KB stops the publish, because a pack without the form bundles still succeeds and the hub has no yank.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Session Forms (wippyai/session#77) moves the Session manifest from
wippy.yamltosrc/wippy.yaml, because itsembedentries resolve against the module sources. The companion publisher readsmodule/wippy.yaml, so it would fail on the first release after that change.What changes
src/wippy.yamlwhen the released tag has one, and the root manifest otherwise.dataflowand Session tags before feat(forms)!: Session Forms V1 (ask_user trait and form state API) session#77 follow the same path as today.src/, a dry-run pack below 400 KB stops the publish. A pack without the form bundles still succeeds, and the hub has no yank.Verification
Dry-run packs of the wippyai/session#77 head on runtime v0.3.57a, the version CI installs:
--config src329d8d3f...329d8d3f...--config src,embedremovedb8609446...The size check was run on sample output for 521.5 KB, 219.2 KB, 1.2 MB and a missing size line. It passes the first and third, and stops the second and fourth.
This workflow has not run from this branch, because it only runs on
workflow_dispatchfor a released tag. The first real run is the first Session release after wippyai/session#77.Merge order
Merge this before wippyai/session#77. It is safe alone, because nothing has
src/wippy.yamluntil wippyai/session#77 lands.