Skip to content

Fix input.monitor.js for relation filters - #1572

Merged
LukeTowers merged 1 commit into
developfrom
fix-relation-filter-onChange
Oct 16, 2026
Merged

LukeTowers merged 1 commit into
developfrom
fix-relation-filter-onChange

Conversation

@mjauvin

@mjauvin mjauvin commented Oct 16, 2026 •

Copy link
Copy Markdown
Member

Prevent filter widgets on model relations from triggering the changed.oc.changeMonitor event

Summary by CodeRabbit

  • Bug Fixes
    • Changes made within .control-filter no longer mark the form as modified or trigger change notifications.

@mjauvin mjauvin added the maintenance PRs that fix bugs, are translation changes or make only minor changes label Oct 16, 2026
@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: fdf56fb5-58fb-433d-8091-fab837b828d1
📥 Commits

Reviewing files that changed from the base of the PR and between da286cd and 759c095.

📒 Files selected for processing: 1
  • modules/system/assets/ui/js/input.monitor.js

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Walkthrough

The input monitor now ignores change events whose targets are inside .control-filter. For those events, ChangeMonitor.change does not mark the form as changed or emit changed.oc.changeMonitor. The file also uses a jQuery-parameterized function wrapper.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 759c0

Filter controls continue through their dedicated update path, while ordinary monitored edits remain unaffected. No actionable merge risk is established.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly describes the main change: preventing input.monitor.js from triggering change events for relation filters.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mjauvin mjauvin added this to the v1.2.15 milestone Oct 16, 2026
@mjauvin mjauvin self-assigned this Oct 16, 2026
@LukeTowers
LukeTowers merged commit 168e7c0 into develop Oct 16, 2026
17 checks passed
@LukeTowers
LukeTowers deleted the fix-relation-filter-onChange branch October 16, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance PRs that fix bugs, are translation changes or make only minor changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants