Repository navigation
Conversation
|
@damsfx ooo, I like this. And in Snowboard too! 😍 Couple of quick comments/questions:
|
Definitely yes! Despite this, a function written in jQuery is still called to update the scroll bar. :o(
The tree structure used for my tests and visible in the animation above contains 550 nodes spread over 4 levels of depth.
For sure. |
|
Latest update :
|
|
@damsfx don't be too concerned if you need to fall back on jQuery to do something in the Backend. A lot of the Backend still uses it and the goal of Snowboard was to remove the dependency of jQuery for the CMS side in particular. |
|
@bennothommo are you happy with this as it is? @damsfx is there a related docs PR? |
Not yet, but I can add a pending PR for this. |
Co-authored-by: Luke Towers <github@luketowers.ca>
@LukeTowers Done : wintercms/docs#243 |
|
@bennothommo I know your time is precious, but if you have 5 mins to take a look and give me a little feedback if you see any improvements to be made. |
|
@damsfx sorry for the delay. Looks great, and the timing of the animation is much better. Only issue I can see now is that it appears that some plugins and themes were added in your most recent commit: Could you make sure these are not included in your branch? Once that's done, @LukeTowers should be able to merge if he's happy with it. |
bennothommo
left a comment
There was a problem hiding this comment.
Approved, pending removal of plugins and themes in recent commit
😱🙄 Oh, I was really distracted! Done ! |
|
@LukeTowers @bennothommo Is this still an interesting PR for WinterCMS !? |
|
@damsfx yes, I had completely forgotten about this. Can you resolve the comments and ping me when it's ready to review? |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughThis PR adds English labels for the Relation widget’s tree actions and adds a backend build entry for compiling its JavaScript asset. Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title clearly describes the main change: adding expand and collapse functionality to the relationship form widget. |
| Docstring Coverage | ✅ Passed | Docstring coverage is 80.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 4 files. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
-Treeview nw compatible with a custom SQL select statement to use for the name
|
@LukeTowers Done some CodeRabbit's suggestions after a merge from develop branch. About him, he's a bit temperamental because every commit causes a bit of hysteria. Minor change: Pending related PRs: |
9ceacbd to
01b0231
Compare
01b0231 to
31b9b01
Compare
This allow relation model with nested tree trait to display a expandable/collapsable list of checkboxes.
The field config allow two new options :
Summary by CodeRabbit
New Features
Style