Clear the static called class when a static extension method throws

[austinderrick]

Summary

ExtendableTrait::extendableCallStatic() sets $extendableStaticCalledClass on the extension before forwarding a static call, and clears it afterward. When the extension method throws, the clear never runs, so the property keeps the caller's class name for later static calls in the process. The clear now runs in a finally block.

Split out of #241 so it can be reviewed on its own.

Testing

testStaticCalledClassIsClearedWhenAStaticExtensionMethodThrows in tests/Extension/ExtendableTraitTest.php fails without the change.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: a1073fa1-2d38-4362-8c02-32430904f6ac

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}