Skip to content

Notifications: Moved subscriptions and watching beside the notifications sidebar - #114

Merged
whereareiam merged 1 commit into
devfrom
fix/notification-subscriptions
Oct 23, 2026
Merged

whereareiam merged 1 commit into
devfrom
fix/notification-subscriptions

Conversation

@whereareiam

@whereareiam whereareiam commented Oct 22, 2026 •

Copy link
Copy Markdown
Owner

Stacked on #113 (fix/org-settings-context); merge that first.

What changes

The notifications sidebar linked to Subscriptions, but that page and Watching dropped the sidebar for Forgejo's switches and boxed filter bar. Both now render in the sidebar layout.

  • The sidebar becomes a shared template (user/notification/sidebar), with Subscriptions and Watching marked when current.
  • The subscribed issues sit in a box headed by All, Open and Closed, with the Type and Sort menus, like the theme's other lists.

Before and after

Dark mode, in the dev preview at 1316px.

Subscriptions: before after
Subscriptions before Subscriptions after

Checks

  • bun run bundle, bunx vitest run (419 tests) and Prettier pass on this branch. bun run lint fails on dev too, because typescript-eslint does not support the installed TypeScript 7.
  • The pull request workflow runs only for pull requests into dev, so these checks ran locally.
  • Checked in the dev preview at desktop and phone width, in dark and light mode.

Preview: http://localhost:3000/notifications/subscriptions

🤖 Generated with Claude Code

@whereareiam whereareiam added the change Changed look, templates or compatibility label Oct 22, 2026
…ns sidebar

The notifications sidebar linked to Subscriptions, but that page and
Watching dropped the sidebar for Forgejo's switches and boxed filter
bar. Both now render in the sidebar layout, which becomes a shared
template with Subscriptions and Watching marked when current. The
subscribed issues sit in a box headed by All, Open and Closed with the
Type and Sort menus, as the theme's other lists.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@whereareiam
whereareiam force-pushed the fix/org-settings-context branch from bd91255 to d04f367 Compare October 23, 2026 05:56
@whereareiam
whereareiam force-pushed the fix/notification-subscriptions branch from c05b45f to 69c5090 Compare October 23, 2026 05:56
Base automatically changed from fix/org-settings-context to dev October 23, 2026 06:03
@whereareiam
whereareiam merged commit eb649b1 into dev Oct 23, 2026
7 checks passed
@whereareiam
whereareiam deleted the fix/notification-subscriptions branch October 23, 2026 06:04
@whereareiam whereareiam changed the title Notifications: Subscriptions and watching beside the notifications sidebar Notifications: Moved subscriptions and watching beside the notifications sidebar Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change Changed look, templates or compatibility

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant